[IDE] Ignore score kinds that represent implicit conversions when solving for code completion #63855
Conversation
| Type BaseTy; | ||
|
|
||
| /// The we were able to determine it, the decl that we are completing on. |
There was a problem hiding this comment.
Comment needs some adjustment :)
|
|
||
| /// If the expression we are completing on statically refers to a metatype, | ||
| /// that is if it's something like 'MyType'. In such cases we want to offer | ||
| /// constructor call pattern completions and don't want to suggested |
| @@ -927,6 +927,9 @@ enum ScoreKind: unsigned int { | |||
| /// A reference to an @unavailable declaration. | |||
| SK_Unavailable, | |||
| /// A reference to an async function in a synchronous context. | |||
| /// | |||
| /// \note Any score kind after thisis considered a conversion that doesn't | |||
lib/Sema/CSRanking.cpp
Outdated
| default: | ||
| break; | ||
| } | ||
| if (isForCodeCompletion() && kind >= SK_SyncInAsync) { |
There was a problem hiding this comment.
Should this be done locally only for locations that involve code completion token in some way (calls with code completion in argument or member references with code completion token?
It's bad that we didn't use SK_NonDefaultLiteral unconditionally today because expressions like 1 + 2 + #^COMPLETE^# - would produce all possible permutations of non-default types like Int32, UInt16, Double etc. even for the first + which degrades performances significantly for filtering.
| bool ExpectsNonVoid; | ||
| bool BaseIsStaticMetaType; | ||
|
|
||
| /// If the code completion expression occurrs as a single statement in a |
ahoppen
force-pushed
the
ahoppen/dont-filter-based-on-conversions
branch
3 times, most recently
from
9dbf865 to
4cedc37
Compare
ahoppen
force-pushed
the
ahoppen/dont-filter-based-on-conversions
branch
3 times, most recently
from
593e52e to
dbe9cec
Compare
…ving for code completion Ignore conversion score increases during code completion to make sure we don't filter solutions that might start receiving the best score based on a choice of the code completion token.
ahoppen
force-pushed
the
ahoppen/dont-filter-based-on-conversions
branch
from
dbe9cec to
3481ac1
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please SourceKit stress test |
|
This PR cases failures on its own and seems to require some of the changes in #63717. Merging the changes here as part of that PR. |
Ignore conversion score increases during code completion to make sure we don't filter solutions that might start receiving the best score based on a choice of the code completion token.