[IDE] Don't rank based on overload choices of function calls that contain the code completion token

Don't rank based on overload choices of function calls that contain the code completion token

Author: ahoppen

lib/AST/ASTNode.cpp

@@ -41,6 +41,7 @@ SourceRange ASTNode::getSourceRange() const {
   if (const auto *I = this->dyn_cast<CaseLabelItem *>()) {
     return I->getSourceRange();
   }
+  assert(!isNull() && "Null ASTNode doesn't have a source range");
   llvm_unreachable("unsupported AST node");
 }
 

lib/Sema/CSRanking.cpp

@@ -906,6 +906,15 @@ SolutionCompareResult ConstraintSystem::compareSolutions(
     // FIXME: Along with the FIXME below, this is a hack to work around
     // problems with restating requirements in protocols.
     identical = false;
+
+    if (auto anchor = overload.locator->getAnchor()) {
+      if (cs.containsIDEInspectionTarget(anchor)) {
+        // Don't rank based on overload choices of function calls that contain the
+        // code completion token.
+        continue;
+      }
+    }
+
     bool decl1InSubprotocol = false;
     bool decl2InSubprotocol = false;
     if (dc1->getContextKind() == DeclContextKind::GenericTypeDecl &&

test/IDE/complete_dont_filter_overloads_with_cc_token.swift

@@ -0,0 +1,25 @@
+// RUN: %empty-directory(%t)
+// RUN: %target-swift-ide-test -batch-code-completion -source-filename %s -filecheck %raw-FileCheck -completion-output-dir %t
+
+func buildView<T>(@MyViewBuilder _ x: () -> T) {}
+
+@resultBuilder struct MyViewBuilder {
+  static func buildBlock(_ content: MyText) -> MyText { content }
+}
+
+struct MyText : Equatable {
+  init(verbatim content: String) {}
+  init<S>(_ content: S) where S : StringProtocol {}
+}
+
+func test(text: String) {
+  buildView {
+    MyText(#^COMPLETE^#text)
+  }
+}
+
+// COMPLETE: Begin completions
+// COMPLETE-DAG: Decl[Constructor]/CurrNominal/Flair[ArgLabels]/TypeRelation[Convertible]: ['(']{#verbatim: String#}[')'][#MyText#];
+// COMPLETE-DAG: Decl[Constructor]/CurrNominal/Flair[ArgLabels]/TypeRelation[Convertible]: ['(']{#(content): StringProtocol#}[')'][#MyText#];
+// COMPLETE-DAG: Decl[LocalVar]/Local/TypeRelation[Convertible]: text[#String#];
+// COMPLETE: End completions