[CodeComplete] Skip conjunction elements unrelated to code completion token 🚥 #59944 #59992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
pr/skip-conjunction-elements
branch
2 times, most recently
from
2dde79f to
8b8b768
Compare
ahoppen
changed the title
ahoppen
force-pushed
the
pr/skip-conjunction-elements
branch
3 times, most recently
from
93cd473 to
69c306b
Compare
ahoppen
changed the title
ahoppen
force-pushed
the
pr/skip-conjunction-elements
branch
from
69c306b to
d30cd06
Compare
ahoppen
changed the title
ahoppen
changed the title
ahoppen
force-pushed
the
pr/skip-conjunction-elements
branch
from
d30cd06 to
693f3e1
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please SourceKit stress test |
ahoppen
force-pushed
the
pr/skip-conjunction-elements
branch
from
693f3e1 to
0a71eb3
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please SourceKit stress test |
ahoppen
changed the title
|
@swift-ci Please SourceKit stress test |
xedin
approved these changes
Feb 3, 2023
lib/Sema/CSSyntacticElement.cpp
Outdated
| @@ -995,6 +995,10 @@ class SyntacticElementConstraintGenerator | |||
| } | |||
| } | |||
|
|
|||
| if (cs.isForCodeCompletion() && !cs.containsIDEInspectionTarget(element)) { | |||
There was a problem hiding this comment.
Nit: could you please add a comment here with brief explanation why this is necessary?
ahoppen
force-pushed
the
pr/skip-conjunction-elements
branch
from
0a71eb3 to
97817ba
Compare
|
@swift-ci Please SourceKit stress test |
ahoppen
force-pushed
the
pr/skip-conjunction-elements
branch
from
97817ba to
52756d1
Compare
|
@swift-ci Please SourceKit stress test |
1 similar comment
|
@swift-ci Please SourceKit stress test |
|
@swift-ci Please SourceKit stress test |
1 similar comment
|
@swift-ci Please SourceKit stress test |
ahoppen
changed the title
Follow-up to swiftlang#63505 Since, when the type is not stated, a variable assumes the type of its initializer that enables out-of-scope variables to be nested inside of some other concrete type i.e. Optional. Resolves: swiftlang#63455
…n application target whose result is not unused This happens if the code completion expression initializes a variable in a multi-statement closure that doesn’t have LeaveClosureBodiesUnchecked set.
…sed code completion
…ode completion token
…ode completion token
ahoppen
force-pushed
the
pr/skip-conjunction-elements
branch
from
52756d1 to
995083c
Compare
ahoppen
requested review from
bnbarham,
CodaFi,
DougGregor and
rintaro
as code owners
|
@swift-ci Please SourceKit stress test |
1 similar comment
|
@swift-ci Please SourceKit stress test |
|
This is now part of #63717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #59944
This should improve performance of code completion inside result builders by not type checking conjunction elements that don’t affect code completion.