Skip to content

Work around a compiler crash building Attachment.record(). #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

Work around a compiler crash building Attachment.record(). #1033

merged 1 commit into from
Mar 21, 2025

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Mar 21, 2025 •
edited
Loading

This PR works around a compiler crash that appeared in CI while building one of the overloads of Attachment.record().

Works around rdar://147543560.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan grynspan added workaround Workaround for an issue in another component (may need to revert later) public-api Affects public API attachments/activities 🖇️ Work related to attachments and/or activities labels Mar 21, 2025
@grynspan grynspan added this to the Swift 6.2 milestone Mar 21, 2025
@grynspan grynspan self-assigned this Mar 21, 2025
@grynspan
Copy link
Contributor Author

@swift-ci test

@rintaro rintaro mentioned this pull request Mar 21, 2025
Merged
@grynspan
Copy link
Contributor Author

See https://ci.swift.org/job/swift-PR-Linux-smoke-test/18797/console

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Work around a compiler crash building Attachment.record().
a115d18 
This PR works around a compiler crash that appeared in CI while building one of
the overloads of `Attachment.record()`.

Works around rdar://147543560.
@grynspan grynspan force-pushed the jgrynspan/work-around-compiler-crash-in-Attachment-record branch from 08a2f4b to a115d18 Compare March 21, 2025 02:51
@grynspan
Copy link
Contributor Author

#722 strikes again!

@grynspan grynspan marked this pull request as ready for review March 21, 2025 02:52
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan merged commit eef2340 into main Mar 21, 2025
1 of 3 checks passed
@grynspan grynspan deleted the jgrynspan/work-around-compiler-crash-in-Attachment-record branch March 21, 2025 03:06
@grynspan grynspan added the macros 🔭 Related to Swift macros such as @Test or #expect label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@rintaro rintaro rintaro approved these changes

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
attachments/activities 🖇️ Work related to attachments and/or activities macros 🔭 Related to Swift macros such as @Test or #expect public-api Affects public API workaround Workaround for an issue in another component (may need to revert later)
Projects
None yet
Milestone
Swift 6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@grynspan @stmontgomery @rintaro