Skip to content

Avoid accidental use of #_sourceLocation in the library target. #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2024
Merged

Avoid accidental use of #_sourceLocation in the library target. #722

merged 1 commit into from
Sep 21, 2024

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Sep 21, 2024 •
edited
Loading

We can't use our own macros in the library target directly.

Resolves rdar://136385550.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Avoid accidental use of #_sourceLocation in the library target.
3838a9c 
We can't use our own macros in the library target directly.

Resolves rdar://136385550.
@grynspan grynspan added bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process labels Sep 21, 2024
@grynspan grynspan requested a review from bnbarham September 21, 2024 00:20
@grynspan grynspan self-assigned this Sep 21, 2024
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

Kudos to @bnbarham for seeing the issue. Will merge as soon as CI finishes.

@grynspan grynspan added this to the Swift 6.1 milestone Sep 21, 2024
@grynspan grynspan requested a review from rintaro September 21, 2024 00:25
@grynspan grynspan merged commit 47b127f into main Sep 21, 2024
3 checks passed
@grynspan grynspan deleted the jgrynspan/136385550-sourcelocation branch September 21, 2024 00:31
@grynspan grynspan mentioned this pull request Mar 21, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@SeanROlszewski SeanROlszewski SeanROlszewski approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

@rintaro rintaro Awaiting requested review from rintaro

Assignees

@grynspan grynspan

Labels
bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process
Projects
None yet
Milestone
Swift 6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@grynspan @stmontgomery @SeanROlszewski