[ASTGen] ObjC improvements #80150
Merged
[ASTGen] ObjC improvements #80150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
ahoppen,
bnbarham,
CodaFi,
hamishknight,
DougGregor,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
* Generate `#selector(...)` expression * Generate `#keyPath(...)` expression * Implicit `@objc` attribute for `@_objcImplementation` attribute
|
@swift-ci Please smoke test |
hamishknight
approved these changes
Mar 20, 2025
| @@ -194,11 +194,98 @@ extension ASTGenVisitor { | |||
| ) | |||
| } | |||
|
|
|||
| func generateObjCSelectorExpr(freestandingMacroExpansion node: some FreestandingMacroExpansionSyntax) -> BridgedObjCSelectorExpr { | |||
| fatalError("unimplemented (objc selector)") | |||
| func generateObjCSelectorExpr(freestandingMacroExpansion node: some FreestandingMacroExpansionSyntax) -> BridgedExpr { | |||
There was a problem hiding this comment.
Do we also need to diagnose the presence of trailing closure + generic arguments?
| } | ||
|
|
||
| func generateObjCKeyPathExpr(freestandingMacroExpansion node: some FreestandingMacroExpansionSyntax) -> BridgedKeyPathExpr { | ||
| fatalError("unimplemented (objc keypath)") | ||
| func generateObjCKeyPathExpr(freestandingMacroExpansion node: some FreestandingMacroExpansionSyntax) -> BridgedExpr { |
|
@swift-ci Please smoke test |
|
swiftlang/swift-testing#1033 |
1 similar comment
|
swiftlang/swift-testing#1033 |
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#selector(...)expression#keyPath(...)expression@objcattribute for@_objcImplementationattribute