refactor towards 1.0 #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: finalize naming and API for 1.0 changes: * rename package to swift-service-boostrap * rename modules to Lifecycle and LifecycleNIOCompat * create top level namespace named Lifecycle * rename LifecycleItem to LifecycleTask, with Lifecycle.Task typealias * define top-level type called ServiceLifecycle where signal handling and backtraces are handled * rename Lifecycle to ComponentLifecycle and conform it to Lifecycle.Task so that lifecycles can be nested * change shutdown to return an error to better conform with Lifecycle.Task api * improve logging * improve API docs * adjust tests
This was
linked to
issues
Apr 9, 2020
Closed
ddossot
approved these changes
Apr 9, 2020
yim-lee
requested changes
Apr 10, 2020
Co-Authored-By: Yim Lee <[email protected]>
ktoso
reviewed
Apr 10, 2020
|
|
||
| let package = Package( | ||
| name: "swift-service-launcher", | ||
| name: "swift-service-bootstrap", |
There was a problem hiding this comment.
It is a bit weird that the word Bootstrap does not appear in code...
I'm hopeful perhaps we could rename some day to lifecycle here OR perhaps
🟢 not blocker tho, let's discuss on forums as well.
ktoso
reviewed
Apr 10, 2020
| // MARK: - Lifecycle (namespace) | ||
|
|
||
| public enum Lifecycle { | ||
| public typealias Task = LifecycleTask |
| /// | ||
| /// - parameters: | ||
| /// - configuration: Defines lifecycle `Configuration` | ||
| public init(configuration: Configuration = .init()) { |
There was a problem hiding this comment.
👍 that config is in init and not start() (i think it used to be there)
| self.configuration = configuration | ||
| self.lifecycle = ComponentLifecycle(label: "Lifecycle", logger: self.configuration.logger) | ||
| // setup backtrace trap as soon as possible | ||
| if configuration.installBacktrace { |
There was a problem hiding this comment.
nitpick :-)
Should installing backtrace be expressed as a LifecycleTask which we automatically add when it's enabled?
There was a problem hiding this comment.
(can be fixed in follow up / separate ticket)
There was a problem hiding this comment.
that's a cool idea! #35
ktoso
approved these changes
Apr 10, 2020
This was referenced Apr 10, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: finalize naming and API towards 1.0
changes: