Skip to content

refactor towards 1.0 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2020
Merged

refactor towards 1.0 #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fba3e40
refactor for 1.0
tomerd Apr 9, 2020
13cfef7
Apply suggestions from code review
tomerd Apr 10, 2020
67d4358
fixup
tomerd Apr 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
import PackageDescription

let package = Package(
name: "swift-service-launcher",
name: "swift-service-bootstrap",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit weird that the word Bootstrap does not appear in code...
I'm hopeful perhaps we could rename some day to lifecycle here OR perhaps

🟢 not blocker tho, let's discuss on forums as well.

platforms: [
.macOS(.v10_12),
],
products: [
.library(name: "ServiceLauncher", targets: ["ServiceLauncher"]),
.library(name: "ServiceLauncherNIOCompat", targets: ["ServiceLauncherNIOCompat"]),
.library(name: "Lifecycle", targets: ["Lifecycle"]),
.library(name: "LifecycleNIOCompat", targets: ["LifecycleNIOCompat"]),
],
dependencies: [
.package(url: "https://github.com/apple/swift-log.git", from: "1.0.0"),
Expand All @@ -18,8 +18,8 @@ let package = Package(
.package(url: "https://github.com/apple/swift-nio.git", from: "2.0.0"), // used in tests
],
targets: [
.target(name: "ServiceLauncher", dependencies: ["Logging", "Metrics", "Backtrace"]),
.target(name: "ServiceLauncherNIOCompat", dependencies: ["ServiceLauncher", "NIO"]),
.testTarget(name: "ServiceLauncherTests", dependencies: ["ServiceLauncher", "ServiceLauncherNIOCompat"]),
.target(name: "Lifecycle", dependencies: ["Logging", "Metrics", "Backtrace"]),
.target(name: "LifecycleNIOCompat", dependencies: ["Lifecycle", "NIO"]),
.testTarget(name: "LifecycleTests", dependencies: ["Lifecycle", "LifecycleNIOCompat"]),
]
)
Loading