finalize naming

[tomerd]

current state

repo name: swift-service-launcher
package name: swift-service-launcher
main module name: ServiceLauncher
main type name: Lifecycle

[tomerd]

@swift-server/service-launcher-members please voice your opinions

[ktoso]

Proposal, taking into account chat and #23

repo name: swift-service-lifecycle
package name: swift-service-lifecycle
main module name: ServiceLifecycle // is it bad that this is the same as the main type?
main type name: ServiceLifecycle
nested type name: ComponentLifecycle

[tomerd]

cc @ddossot @weissi @yim-lee

[weissi]

main module name: ServiceLifecycle // is it bad that this is the same as the main type?

Unfortunately, it's not great. If you ever need to disambiguate, you won't be able to. ServiceLifecycle.ServiceLifecycle won't work :(.

Apart from that I think the proposal is great! What about

repo name: swift-service-lifecycle
package name: swift-service-lifecycle
main module name: Lifecycle
main type name: ServiceLifecycle
nested type name: ComponentLifecycle

@tomerd think that's acceptable with PM?

[ktoso]

A bit unfortunate with the language here that ServiceLifecycle.ServiceLifecycle can't work but given that: This looks good @weissi 👍

[weissi]

@ktoso yes, I think they're working on fixing this. Still the case for 5.2 though:

$ cat test.swift 
import A
import B

let thing: A.A? = nil

// MODULE: A

public struct A {
    public init() {}
}

// MODULE: B

public struct A {
    public init() {}
}

$ make-single-file-spm test.swift build
all extra modules: A B
SwiftPM package in:
  /tmp/test_package_MpRR4o
  /tmp/test_package_MpRR4o/.build/release/TestApp
/private/tmp/test_package_MpRR4o/Sources/TestApp/main.swift:4:12: error: 'A' is ambiguous for type lookup in this context
let thing: A.A? = nil
           ^
/private/tmp/test_package_MpRR4o/Sources/A/module.swift:8:15: note: found this candidate
public struct A {
              ^
/private/tmp/test_package_MpRR4o/Sources/B/module.swift:14:15: note: found this candidate
public struct A {
              ^

[weissi]

(btw make-single-file-spm lives in swift-nio/dev/ if you want to try the exact commands above)

[ktoso]

Thanks a nifty little scripts thank you :-)

[tomerd]

@weissi @ktoso unfortunately swift-service-lifecycle is not approved :(