Skip to content

Update deployment tests in respect of JUnit 5 checkstyle rule #17106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update deployment tests in respect of JUnit 5 checkstyle rule #17106

wants to merge 1 commit into from

Conversation

@ielatif
Copy link
Contributor

@ielatif ielatif commented Jun 11, 2019 •
edited
Loading

Fixes master CI build failure.

[INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ spring-boot-deployment-test-glassfish ---
[INFO]
[INFO] --- maven-checkstyle-plugin:3.0.0:check (checkstyle-validation) @ spring-boot-deployment-test-glassfish ---
[INFO] There are 2 errors reported by Checkstyle 8.18 with src/checkstyle/checkstyle.xml ruleset.
[ERROR] src/test/java/sample/SampleGlassfishDeployApplicationIT.java:[34,9] (extension) SpringJUnit5: "Test method 'testHome' should not be public."
[ERROR] src/test/java/sample/SampleGlassfishDeployApplicationIT.java:[43,9] (extension) SpringJUnit5: "Test method 'testHealth' should not be public."

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 11, 2019
@ielatif ielatif mentioned this pull request Jun 11, 2019
Closed
@ielatif ielatif changed the title Update SampleGlassfishDeployApplicationIT in respect of JUnit 5 checkstyle rule Update deployment tests in respect of JUnit 5 checkstyle rule Jun 11, 2019
@ielatif ielatif force-pushed the glassfish-deploy-it branch from c87ed79 to 3691e40 Compare June 11, 2019 15:09
@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 11, 2019
@philwebb philwebb added this to the 2.2.x milestone Jun 11, 2019
@philwebb
Copy link
Member

philwebb commented Jun 11, 2019

I managed to completely miss these! Thanks a lot for the PR.

philwebb pushed a commit that referenced this pull request Jun 11, 2019
@ielatif @philwebb
Fix deployment tests JUnit 5 checkstyle issues
35dc798 
See gh-17106
@philwebb philwebb closed this in 1d5647b Jun 11, 2019
@philwebb philwebb modified the milestones: 2.2.x, 2.2.0.M4 Jun 11, 2019
@ielatif
Copy link
Contributor Author

ielatif commented Jun 11, 2019

You're welcome. Happy to contribute 😊

@ielatif ielatif deleted the glassfish-deploy-it branch June 11, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type: task A general task

Projects

None yet

Milestone

2.2.0.M4

Development

Successfully merging this pull request may close these issues.

3 participants

@ielatif @philwebb @spring-projects-issues