Skip to content

Conversation

@ielatif
Copy link
Contributor

@ielatif ielatif commented Jun 10, 2019

This commit adds a sample to verify the use of JUnit 4 and the Vintage Engine.
Closes #17070.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 10, 2019
@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 10, 2019
@mbhave mbhave added this to the 2.2.x milestone Jun 10, 2019
@ielatif ielatif force-pushed the gh-17070 branch 2 times, most recently from 64ca56d to d24446f Compare June 11, 2019 08:44
@ielatif
Copy link
Contributor Author

ielatif commented Jun 11, 2019

@philwebb @mbhave @wilkinsona JUnit 5 checkstyle rules introduced in #17093 are applied to spring-boot-sample-junit-vintage which cause it to fail.
Any idea on how to disable only JUnit 5 checkstyle rules?

@ielatif
Copy link
Contributor Author

ielatif commented Jun 11, 2019

May be add a suppression for SampleJunitVintageApplicationTests in checkstyle-suppressions.xml?

@wilkinsona
Copy link
Member

@ielatif Yes, I think that's the right approach.

@ielatif
Copy link
Contributor Author

ielatif commented Jun 11, 2019

@wilkinsona raised this PR to fix master CI build failure

This commit adds a sample to verify the use of JUnit 4 and the Vintage Engine.
Closes spring-projects#17070.
@snicoll snicoll self-assigned this Jun 19, 2019
@snicoll snicoll modified the milestones: 2.2.x, 2.2.0.M5 Jun 19, 2019
snicoll pushed a commit that referenced this pull request Jun 19, 2019
This commit adds a sample to verify the use of JUnit 4 and the Vintage
Engine.

See gh-17100
snicoll added a commit that referenced this pull request Jun 19, 2019
@snicoll snicoll closed this in 2d70daf Jun 19, 2019
@snicoll
Copy link
Member

snicoll commented Jun 19, 2019

@ielatif thanks for the PR. I've polished in two main areas:

  1. I think what we want is to show that adding the starter with no further modification allows us to run a Junit 4-based test and the exclusions could potentially hide a problem. I've removed them
  2. There is no need to start an embedded web server for such a sample so I rewrote the test to use mock MVC.

@ielatif
Copy link
Contributor Author

ielatif commented Jun 19, 2019

@snicoll

  1. I think what we want is to show that adding the starter with no further modification allows us to run a Junit 4-based test and the exclusions could potentially hide a problem. I've removed them

Totaly agree 👍

2. There is no need to start an embedded web server for such a sample so I rewrote the test to use mock MVC.

I was thinking of the sample as a sample application (application running an embedded web server) and not as a smoke test like @philwebb mentioned in a newly raised feature.

@ielatif ielatif deleted the gh-17070 branch June 19, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a sample to verify the use of JUnit 4 and the Vintage Engine

6 participants