Merge pull request #17106 from ielatif

* pr/17106:
  Fix deployment tests JUnit 5 checkstyle issues

Closes gh-17106

Author: philwebb

spring-boot-tests/spring-boot-deployment-tests/spring-boot-deployment-test-glassfish/src/test/java/sample/SampleGlassfishDeployApplicationIT.java

@@ -32,7 +32,7 @@ public class SampleGlassfishDeployApplicationIT {
 	private int port = Integer.valueOf(System.getProperty("port"));
 
 	@Test
-	public void testHome() throws Exception {
+	void testHome() throws Exception {
 		String url = "http://localhost:" + this.port + "/bootapp/";
 		System.out.println(url);
 		ResponseEntity<String> entity = new TestRestTemplate().getForEntity(url, String.class);
@@ -41,7 +41,7 @@ public void testHome() throws Exception {
 	}
 
 	@Test
-	public void testHealth() throws Exception {
+	void testHealth() throws Exception {
 		String url = "http://localhost:" + this.port + "/bootapp/actuator/health";
 		System.out.println(url);
 		ResponseEntity<String> entity = new TestRestTemplate().getForEntity(url, String.class);

spring-boot-tests/spring-boot-deployment-tests/spring-boot-deployment-test-tomcat/src/test/java/sample/SampleTomcatDeployApplicationIT.java

@@ -38,15 +38,15 @@ public class SampleTomcatDeployApplicationIT {
 	private int port = Integer.valueOf(System.getProperty("port"));
 
 	@Test
-	public void testHome() throws Exception {
+	void testHome() throws Exception {
 		String url = "http://localhost:" + this.port + "/bootapp/";
 		ResponseEntity<String> entity = this.rest.getForEntity(url, String.class);
 		assertThat(entity.getStatusCode()).isEqualTo(HttpStatus.OK);
 		assertThat(entity.getBody()).isEqualTo("Hello World");
 	}
 
 	@Test
-	public void testHealth() throws Exception {
+	void testHealth() throws Exception {
 		String url = "http://localhost:" + this.port + "/bootapp/actuator/health";
 		System.out.println(url);
 		ResponseEntity<String> entity = new TestRestTemplate().getForEntity(url, String.class);
@@ -55,34 +55,34 @@ public void testHealth() throws Exception {
 	}
 
 	@Test
-	public void errorFromExceptionForRequestAcceptingAnythingProducesAJsonResponse() throws Exception {
+	void errorFromExceptionForRequestAcceptingAnythingProducesAJsonResponse() throws Exception {
 		assertThatPathProducesExpectedResponse("/bootapp/exception", MediaType.ALL, MediaType.APPLICATION_JSON);
 	}
 
 	@Test
-	public void errorFromExceptionForRequestAcceptingJsonProducesAJsonResponse() throws Exception {
+	void errorFromExceptionForRequestAcceptingJsonProducesAJsonResponse() throws Exception {
 		assertThatPathProducesExpectedResponse("/bootapp/exception", MediaType.APPLICATION_JSON,
 				MediaType.APPLICATION_JSON);
 	}
 
 	@Test
-	public void errorFromExceptionForRequestAcceptingHtmlProducesAnHtmlResponse() throws Exception {
+	void errorFromExceptionForRequestAcceptingHtmlProducesAnHtmlResponse() throws Exception {
 		assertThatPathProducesExpectedResponse("/bootapp/exception", MediaType.TEXT_HTML, MediaType.TEXT_HTML);
 	}
 
 	@Test
-	public void sendErrorForRequestAcceptingAnythingProducesAJsonResponse() throws Exception {
+	void sendErrorForRequestAcceptingAnythingProducesAJsonResponse() throws Exception {
 		assertThatPathProducesExpectedResponse("/bootapp/send-error", MediaType.ALL, MediaType.APPLICATION_JSON);
 	}
 
 	@Test
-	public void sendErrorForRequestAcceptingJsonProducesAJsonResponse() throws Exception {
+	void sendErrorForRequestAcceptingJsonProducesAJsonResponse() throws Exception {
 		assertThatPathProducesExpectedResponse("/bootapp/send-error", MediaType.APPLICATION_JSON,
 				MediaType.APPLICATION_JSON);
 	}
 
 	@Test
-	public void sendErrorForRequestAcceptingHtmlProducesAnHtmlResponse() throws Exception {
+	void sendErrorForRequestAcceptingHtmlProducesAnHtmlResponse() throws Exception {
 		assertThatPathProducesExpectedResponse("/bootapp/send-error", MediaType.TEXT_HTML, MediaType.TEXT_HTML);
 	}
 

spring-boot-tests/spring-boot-deployment-tests/spring-boot-deployment-test-tomee/src/test/java/sample/SampleTomEEDeployApplicationIT.java

@@ -32,15 +32,15 @@ public class SampleTomEEDeployApplicationIT {
 	private int port = Integer.valueOf(System.getProperty("port"));
 
 	@Test
-	public void testHome() throws Exception {
+	void testHome() throws Exception {
 		String url = "http://localhost:" + this.port + "/bootapp/";
 		ResponseEntity<String> entity = new TestRestTemplate().getForEntity(url, String.class);
 		assertThat(entity.getStatusCode()).isEqualTo(HttpStatus.OK);
 		assertThat(entity.getBody()).isEqualTo("Hello World");
 	}
 
 	@Test
-	public void testHealth() throws Exception {
+	void testHealth() throws Exception {
 		String url = "http://localhost:" + this.port + "/bootapp/actuator/health";
 		System.out.println(url);
 		ResponseEntity<String> entity = new TestRestTemplate().getForEntity(url, String.class);

spring-boot-tests/spring-boot-deployment-tests/spring-boot-deployment-test-wildfly/src/test/java/sample/SampleWildFlyDeployApplicationIT.java

@@ -32,15 +32,15 @@ public class SampleWildFlyDeployApplicationIT {
 	private int port = Integer.valueOf(System.getProperty("port"));
 
 	@Test
-	public void testHome() throws Exception {
+	void testHome() throws Exception {
 		String url = "http://localhost:" + this.port + "/bootapp/";
 		ResponseEntity<String> entity = new TestRestTemplate().getForEntity(url, String.class);
 		assertThat(entity.getStatusCode()).isEqualTo(HttpStatus.OK);
 		assertThat(entity.getBody()).isEqualTo("Hello World");
 	}
 
 	@Test
-	public void testHealth() throws Exception {
+	void testHealth() throws Exception {
 		String url = "http://localhost:" + this.port + "/bootapp/actuator/health";
 		System.out.println(url);
 		ResponseEntity<String> entity = new TestRestTemplate().getForEntity(url, String.class);

spring-boot-tests/spring-boot-deployment-tests/spring-boot-deployment-test-wlp/src/test/java/sample/SampleWlpDeployApplicationIT.java

@@ -32,15 +32,15 @@ public class SampleWlpDeployApplicationIT {
 	private int port = Integer.valueOf(System.getProperty("port"));
 
 	@Test
-	public void testHome() throws Exception {
+	void testHome() throws Exception {
 		String url = "http://localhost:" + this.port + "/bootapp/";
 		ResponseEntity<String> entity = new TestRestTemplate().getForEntity(url, String.class);
 		assertThat(entity.getStatusCode()).isEqualTo(HttpStatus.OK);
 		assertThat(entity.getBody()).isEqualTo("Hello World");
 	}
 
 	@Test
-	public void testHealth() throws Exception {
+	void testHealth() throws Exception {
 		String url = "http://localhost:" + this.port + "/bootapp/actuator/health";
 		System.out.println(url);
 		ResponseEntity<String> entity = new TestRestTemplate().getForEntity(url, String.class);