native gems, better system library support, more platform support #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-resurrect-native-gems
branch
from
9d93971 to
8498cdb
Compare
flavorjones
force-pushed
the
flavorjones-resurrect-native-gems
branch
5 times, most recently
from
d07ec8a to
65d9e94
Compare
flavorjones
force-pushed
the
flavorjones-resurrect-native-gems
branch
3 times, most recently
from
d3c02c1 to
05c9f8c
Compare
This was referenced May 26, 2022
flavorjones
changed the title
This was referenced May 26, 2022
patterned from: https://github.com/flavorjones/ruby-c-extensions-explained with the ultimate goal being to ship precompiled native gems for some set of supported platforms, and support users compiling from source for all the other platforms. note that mini_portile is now an install-time dependency (which we'll remove for precompiled gems)
to expose the value returned by sqlite3_libversion. This is a convenience to allow comparison or the compile-time version of sqlite3 (SQLite3::SQLITE_VERSION) to the version being dynamically loaded at runtime.
to quash warnings
use an allowlist of environment variables for configuration
because truffleruby is rounding
flavorjones
force-pushed
the
flavorjones-resurrect-native-gems
branch
2 times, most recently
from
154e3d0 to
efa5e3e
Compare
|
At this point, this branch is functionally ready to merge. I'll take a bit of time later today to document installation in the README but otherwise, unless there are objections, I plan to merge in the next day or so. |
flavorjones
force-pushed
the
flavorjones-resurrect-native-gems
branch
from
efa5e3e to
2b47cc2
Compare
Co-authored-by: Mike Dalessio <[email protected]>
This adds the ability to download a sqlite3 tarball with `--download-dependencies`
because when we test the installed gem in CI we delete `lib`, but the gemspec is always loaded by bundler anyway.
see CONTRIBUTING.md for an explanation
also rename the github actions pipelines to be more meaningful
flavorjones
force-pushed
the
flavorjones-resurrect-native-gems
branch
from
58205b7 to
95e16d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much time has passed since the last time we shipped precompiled native gems for sqlite3, and we need to do some work to get them to build now.
This branch is a work-in-progress which will close #301 and close #313
look into using https://rubygems.org/gems/native-package-installer/ for system library usersmsys2_mingw_dependenciesshould not be present for native gems