Adds the ability to show/hide input bar. Closes #203. Closes #229 #230

dzenbot · 2015-08-12T04:33:04Z

@aryaxt: I've made some improvements and refactorings to your original PR in #229:

Renamed hideInputBar:animated: to setTextInputbarHidden:animated:
Dismissed the keyboard and the auto-completion view right after hiding the textInputBar
Fixed cases where hiding the textInputBar wouldn't be possible when the keyboard was up
Avoided hiding the textInputBar with alpha, instead fixed some auto-layout constraints so the textView would follow the dismissal animation

Known bugs:

when rotating the device, the scrollView's wouldn't extend to the bottom of the screen when the textInputBar is hidden.

Please try pulling this branch. Thanks for this great improvement!

aryaxt · 2015-08-12T05:32:03Z

Source/Classes/SLKTextViewController.m

This logic is not needed anymore, duration would always be 0.25

Well, this is to avoid calling the logic in. UIView animation block if the textInputBat should be hidden without animation.

Oh, my bad. You're right!
I'll fix it in this branch.

aryaxt · 2015-08-12T05:33:02Z

@dzenbot Thanks for the quick response, I made a comment and already pulled the changes. Would you like me to update that line of code in my branch?

aryaxt · 2015-08-13T00:24:26Z

@dzenbot This branch is broken, the bar disappears as soon as textfield becomes first response.

dzenbot · 2015-08-13T03:54:59Z

Would appreciate more context about the issue you're facing.
It behaves just great on the sample project.

aryaxt · 2015-08-13T16:45:13Z

I was ending up with this state, will do more testing on this today and comment back.

dzenbot · 2015-08-13T16:50:20Z

I noticed that you have a subview above your cells. Is that a section header view? Or a custom subview?

Can you repro on the sample project?

aryaxt · 2015-08-13T16:59:01Z

That's just a UIView added on top of the main tableView.
I had to release a new version, so I checked out 1.5.1 and added the code in my original PR.

I'll update to that branch again sometimes today or tomorrow, and will report back.

Thanks

aryaxt · 2015-08-16T17:23:40Z

Investigated this, and it seem like the issue is not related to this branch. This issue was introduced in 1.6.
Switching to 1.5.2 resolves the issue.

textview becomes first responder but the toolbar doesn't appear. It looks like it's hidden behind another view, because as I'm scrolling down and dismissing the keyboard interactively I can see parts of the toolbar animating down along with the keyboard

Here is the viewHierarchy when the toolbar is hidden:

po [self.view recursiveDescription]
<UIView: 0x7fac1d8c5280; frame = (0 0; 375 667); autoresize = W+H; layer = <CALayer: 0x7fac1d849790>>
   | <UITableView: 0x7fac1d065800; frame = (0 64; 375 301); gestureRecognizers = <NSArray: 0x7fac1d8661d0>; layer = <CALayer: 0x7fac1d807290>; contentOffset: {0, 0}; contentSize: {375, 236}>
   |    | <UITableViewWrapperView: 0x7fac1d886480; frame = (0 0; 375 301); gestureRecognizers = <NSArray: 0x7fac1d83a250>; layer = <CALayer: 0x7fac1d838180>; contentOffset: {0, 0}; contentSize: {375, 301}>
   |    |    | <CSConversationMessageTableViewCell: 0x7fac1dcb8150; baseClass = UITableViewCell; frame = (0 177; 375 59); autoresize = W; layer = <CALayer: 0x7fac1dcb7990>>
   |    |    |    | <UITableViewCellContentView: 0x7fac1dcb7e20; frame = (0 0; 375 59); opaque = NO; gestureRecognizers = <NSArray: 0x7fac1dcc2550>; layer = <CALayer: 0x7fac1dcb7ef0>>
   |    |    |    |    | <UIImageView: 0x7fac1dcb8460; frame = (15 15; 40 40); clipsToBounds = YES; opaque = NO; autoresize = RM+BM; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1dcb7f10>>
   |    |    |    |    | <UITextView: 0x7fac1b85fc00; frame = (70 15; 290 34); text = 'sdfsdf
Jul 28 • 11:20 AM'; clipsToBounds = YES; autoresize = W+RM+BM; gestureRecognizers = <NSArray: 0x7fac1dcb9730>; layer = <CALayer: 0x7fac1dcb85e0>; contentOffset: {0, 0}; contentSize: {290, 34}>
   |    |    |    |    |    | <<_UITextContainerView: 0x7fac1dcba430; frame = (0 0; 290 34); layer = <_UITextTiledLayer: 0x7fac1dcba560>> minSize = {290, 34}, maxSize = {290, 34}, textContainer = <NSTextContainer: 0x7fac1dcb9c10 size = (290.000000,34.000000); widthTracksTextView = YES; heightTracksTextView = YES>; exclusionPaths = 0x0; lineBreakMode = 0>
   |    |    |    |    |    | <UIImageView: 0x7fac1dcb8ab0; frame = (52 31.5; 240.5 2.5); alpha = 0; opaque = NO; autoresize = TM; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1dcb8c50>>
   |    |    |    |    |    | <UIImageView: 0x7fac1dcc0b00; frame = (287.5 5; 2.5 28); alpha = 0; opaque = NO; autoresize = LM; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1dcc2d80>>
   |    |    |    | <_UITableViewCellSeparatorView: 0x7fac1dcc1f80; frame = (15 66; 305 1); layer = <CALayer: 0x7fac1dcc2070>>
   |    |    | <CSConversationMessageTableViewCell: 0x7fac1dc67020; baseClass = UITableViewCell; frame = (0 118; 375 59); autoresize = W; layer = <CALayer: 0x7fac1dc67330>>
   |    |    |    | <UITableViewCellContentView: 0x7fac1dc23f00; frame = (0 0; 375 59); opaque = NO; gestureRecognizers = <NSArray: 0x7fac1dcb4d10>; layer = <CALayer: 0x7fac1dc67350>>
   |    |    |    |    | <UIImageView: 0x7fac1dc23fd0; frame = (15 15; 40 40); clipsToBounds = YES; opaque = NO; autoresize = RM+BM; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1dc67370>>
   |    |    |    |    | <UITextView: 0x7fac1b88c400; frame = (70 15; 290 34); text = 'sdfsdf
Jul 28 • 11:19 AM'; clipsToBounds = YES; autoresize = W+RM+BM; gestureRecognizers = <NSArray: 0x7fac1dc752f0>; layer = <CALayer: 0x7fac1dc24160>; contentOffset: {0, 0}; contentSize: {290, 34}>
   |    |    |    |    |    | <<_UITextContainerView: 0x7fac1dc907e0; frame = (0 0; 290 34); layer = <_UITextTiledLayer: 0x7fac1dc75ff0>> minSize = {290, 34}, maxSize = {290, 34}, textContainer = <NSTextContainer: 0x7fac1dc757d0 size = (290.000000,34.000000); widthTracksTextView = YES; heightTracksTextView = YES>; exclusionPaths = 0x0; lineBreakMode = 0>
   |    |    |    |    |    | <UIImageView: 0x7fac1dc8dd30; frame = (52 31.5; 240.5 2.5); alpha = 0; opaque = NO; autoresize = TM; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1dc7e0f0>>
   |    |    |    |    |    | <UIImageView: 0x7fac1dcb3bf0; frame = (287.5 5; 2.5 28); alpha = 0; opaque = NO; autoresize = LM; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1dcb3bb0>>
   |    |    |    | <_UITableViewCellSeparatorView: 0x7fac1dcb4740; frame = (15 66; 305 1); layer = <CALayer: 0x7fac1dcb4830>>
   |    |    | <CSConversationMessageTableViewCell: 0x7fac1dc26e80; baseClass = UITableViewCell; frame = (0 59; 375 59); autoresize = W; layer = <CALayer: 0x7fac1dc36b80>>
   |    |    |    | <UITableViewCellContentView: 0x7fac1dc8bdc0; frame = (0 0; 375 59); opaque = NO; gestureRecognizers = <NSArray: 0x7fac1dc8c8d0>; layer = <CALayer: 0x7fac1dc36ba0>>
   |    |    |    |    | <UIImageView: 0x7fac1dc29f90; frame = (15 15; 40 40); clipsToBounds = YES; opaque = NO; autoresize = RM+BM; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1dc36bc0>>
   |    |    |    |    | <UITextView: 0x7fac1b8a7800; frame = (70 15; 290 34); text = 'sdfsdfsdf
Jul 28 • 11:19 ...'; clipsToBounds = YES; autoresize = W+RM+BM; gestureRecognizers = <NSArray: 0x7fac1dc28c90>; layer = <CALayer: 0x7fac1dc8bef0>; contentOffset: {0, 0}; contentSize: {290, 34}>
   |    |    |    |    |    | <<_UITextContainerView: 0x7fac1dc364f0; frame = (0 0; 290 34); layer = <_UITextTiledLayer: 0x7fac1dc1cd50>> minSize = {290, 34}, maxSize = {290, 34}, textContainer = <NSTextContainer: 0x7fac1dc2e2d0 size = (290.000000,34.000000); widthTracksTextView = YES; heightTracksTextView = YES>; exclusionPaths = 0x0; lineBreakMode = 0>
   |    |    |    |    |    | <UIImageView: 0x7fac1dcaa460; frame = (52 31.5; 240.5 2.5); alpha = 0; opaque = NO; autoresize = TM; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1dc12f50>>
   |    |    |    |    |    | <UIImageView: 0x7fac1dc77d00; frame = (287.5 5; 2.5 28); alpha = 0; opaque = NO; autoresize = LM; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1dc77cc0>>
   |    |    |    | <_UITableViewCellSeparatorView: 0x7fac1dc7c4e0; frame = (15 66; 305 1); layer = <CALayer: 0x7fac1dc7ba30>>
   |    |    | <CSConversationMessageTableViewCell: 0x7fac1dc1c890; baseClass = UITableViewCell; frame = (0 0; 375 59); autoresize = W; layer = <CALayer: 0x7fac1dc563b0>>
   |    |    |    | <UITableViewCellContentView: 0x7fac1dc6fc60; frame = (0 0; 375 59); opaque = NO; gestureRecognizers = <NSArray: 0x7fac1dcb11b0>; layer = <CALayer: 0x7fac1dc5a3e0>>
   |    |    |    |    | <UIImageView: 0x7fac1dc8c970; frame = (15 15; 40 40); clipsToBounds = YES; opaque = NO; autoresize = RM+BM; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1dc61380>>
   |    |    |    |    | <UITextView: 0x7fac1b88b600; frame = (70 15; 290 34); text = 'test
Jul 28 • 11:19 AM'; clipsToBounds = YES; autoresize = W+RM+BM; gestureRecognizers = <NSArray: 0x7fac1dc10470>; layer = <CALayer: 0x7fac1dc211a0>; contentOffset: {0, 0}; contentSize: {290, 34}>
   |    |    |    |    |    | <<_UITextContainerView: 0x7fac1dc6ee40; frame = (0 0; 290 34); layer = <_UITextTiledLayer: 0x7fac1dcae830>> minSize = {290, 34}, maxSize = {290, 34}, textContainer = <NSTextContainer: 0x7fac1dc1a9a0 size = (290.000000,34.000000); widthTracksTextView = YES; heightTracksTextView = YES>; exclusionPaths = 0x0; lineBreakMode = 0>
   |    |    |    |    |    | <UIImageView: 0x7fac1dc62f80; frame = (52 31.5; 240.5 2.5); alpha = 0; opaque = NO; autoresize = TM; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1dcacc90>>
   |    |    |    |    |    | <UIImageView: 0x7fac1dc5d3c0; frame = (287.5 5; 2.5 28); alpha = 0; opaque = NO; autoresize = LM; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1dc24e00>>
   |    |    |    | <_UITableViewCellSeparatorView: 0x7fac1dc5e680; frame = (15 66; 305 1); layer = <CALayer: 0x7fac1dc9bcb0>>
   |    | <UIImageView: 0x7fac1f815c90; frame = (0 298.5; 375 2.5); alpha = 0; opaque = NO; autoresize = TM; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1f815c70>>
   |    | <UIImageView: 0x7fac1f8164a0; frame = (372.5 616; 2.5 7); alpha = 0; opaque = NO; autoresize = LM; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1f816480>>
   | <UITableView: 0x7fac1d0b3200; frame = (0 365; 375 0); clipsToBounds = YES; gestureRecognizers = <NSArray: 0x7fac1d8c5990>; layer = <CALayer: 0x7fac1d8b6c90>; contentOffset: {0, 0}; contentSize: {375, 0}>
   |    | <UITableViewWrapperView: 0x7fac1d8c5ff0; frame = (0 0; 375 0); gestureRecognizers = <NSArray: 0x7fac1d8c63e0>; layer = <CALayer: 0x7fac1d8b62a0>; contentOffset: {0, 0}; contentSize: {375, 0}>
   |    | <UIView: 0x7fac1d8c6950; frame = (0 0; 750 0.5); autoresize = W; layer = <CALayer: 0x7fac1d8c6a20>>
   |    | <UIImageView: 0x7fac1f8171b0; frame = (0 -2.5; 375 2.5); alpha = 0; opaque = NO; autoresize = TM; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1f817190>>
   |    | <UIImageView: 0x7fac1f8179c0; frame = (372.5 -36; 2.5 36); alpha = 0; opaque = NO; autoresize = LM; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1f8179a0>>
   | <SLKTypingIndicatorView: 0x7fac1d8c6b20; frame = (0 365; 375 0); hidden = YES; layer = <CALayer: 0x7fac1d8c6c60>>
   |    | <UILabel: 0x7fac1d8c6d60; frame = (40 0; 325 0); userInteractionEnabled = NO; layer = <_UILabelLayer: 0x7fac1d8c6ec0>>
   |    |    | <_UILabelContentLayer: 0x7fac1f802c70> (layer)
   | <SLKTextInputbar: 0x7fac1d8c7dc0; baseClass = UIToolbar; frame = (0 365; 375 44); clipsToBounds = YES; layer = <CALayer: 0x7fac1d8c8000>>
   |    | <_UIToolbarBackground: 0x7fac1d8f8980; frame = (0 0; 375 44); userInteractionEnabled = NO; layer = <CALayer: 0x7fac1d8f8a90>>
   |    |    | <_UIBackdropView: 0x7fac1acb3290; frame = (0 0; 375 44); opaque = NO; autoresize = W+H; userInteractionEnabled = NO; layer = <_UIBackdropViewLayer: 0x7fac1acb3500>>
   |    |    |    | <_UIBackdropEffectView: 0x7fac1df1f820; frame = (0 0; 375 44); clipsToBounds = YES; opaque = NO; autoresize = W+H; userInteractionEnabled = NO; layer = <CABackdropLayer: 0x7fac1df10df0>>
   |    |    |    | <UIView: 0x7fac1df04020; frame = (0 0; 375 44); opaque = NO; autoresize = W+H; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1df16740>>
   |    |    |    | <UIView: 0x7fac1df040f0; frame = (0 0; 375 44); alpha = 0.85; opaque = NO; autoresize = W+H; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1acbbd20>>
   |    | <UIView: 0x7fac1d8d05e0; frame = (0 0; 375 0); clipsToBounds = YES; hidden = YES; layer = <CALayer: 0x7fac1d8d06b0>>
   |    |    | <UILabel: 0x7fac1d8d06d0; frame = (76 0; 223 0); text = 'Editing Message'; userInteractionEnabled = NO; layer = <_UILabelLayer: 0x7fac1d8d0830>>
   |    |    | <UIButton: 0x7fac1d8d1100; frame = (8 0; 60 0); opaque = NO; layer = <CALayer: 0x7fac1d8d12e0>>
   |    |    |    | <UIButtonLabel: 0x7fac1d8d1380; frame = (0 -9; 48 18); text = 'Cancel'; opaque = NO; userInteractionEnabled = NO; layer = <_UILabelLayer: 0x7fac1d8d14f0>>
   |    |    | <UIButton: 0x7fac1d8d2cc0; frame = (307 0; 60 0); opaque = NO; layer = <CALayer: 0x7fac1d8d2ea0>>
   |    |    |    | <UIButtonLabel: 0x7fac1d8d2f40; frame = (25 -9; 35 18); text = 'Save'; opaque = NO; userInteractionEnabled = NO; layer = <_UILabelLayer: 0x7fac1d8d30b0>>
   |    | <UIButton: 0x7fac1d8d5470; frame = (8 2; 30 40); opaque = NO; layer = <CALayer: 0x7fac1d8d4d00>>
   |    |    | <UIImageView: 0x7fac1d8dbac0; frame = (0 0; 30 40); clipsToBounds = YES; opaque = NO; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1d8dba50>>
   |    |    | <UIButtonLabel: 0x7fac1d8d5650; frame = (0 0; 0 0); hidden = YES; opaque = NO; userInteractionEnabled = NO; layer = <_UILabelLayer: 0x7fac1d8d5170>>
   |    |    |    | <_UILabelContentLayer: 0x7fac1d8e03f0> (layer)
   |    | <UIButton: 0x7fac1d8c8020; frame = (375 7; 0 30); opaque = NO; layer = <CALayer: 0x7fac1d8c8200>>
   |    |    | <UIButtonLabel: 0x7fac1d8c8260; frame = (0 6; 0 18); text = 'Send'; opaque = NO; userInteractionEnabled = NO; layer = <_UILabelLayer: 0x7fac1d8c83d0>>
   |    | <SLKTextView: 0x7fac1d0b3a00; baseClass = UITextView; frame = (46 5; 321 34); text = ''; clipsToBounds = YES; gestureRecognizers = <NSArray: 0x7fac1d8ca640>; layer = <CALayer: 0x7fac1d8c8490>; contentOffset: {0, 0}; contentSize: {321, 34}>
   |    |    | <UILabel: 0x7fac1d8cdb30; frame = (9 8; 118 18); text = 'Write a message...'; autoresizesSubviews = NO; userInteractionEnabled = NO; layer = <_UILabelLayer: 0x7fac1d8cda70>>
   |    |    | <<_UITextContainerView: 0x7fac1d8cb340; frame = (0 0; 321 34); layer = <_UITextTiledLayer: 0x7fac1d8cb470>> minSize = {321, 0}, maxSize = {3.4028234663852886e+38, 3.4028234663852886e+38}, textContainer = <NSTextContainer: 0x7fac1d8cab20 size = (317.000000,inf); widthTracksTextView = YES; heightTracksTextView = NO>; exclusionPaths = 0x0; lineBreakMode = 0>
   |    |    |    | <_UITileLayer: 0x7fac1acec4e0> (layer)
   |    |    |    | <_UITileLayer: 0x7fac1d8f93f0> (layer)
   |    |    |    | <_UITileLayer: 0x7fac1d8f93d0> (layer)
   |    |    |    | <UITextSelectionView: 0x7fac1d8ccdf0; frame = (0 0; 0 0); userInteractionEnabled = NO; layer = <CALayer: 0x7fac1d8ccf10>>
   |    |    |    |    | <UIView: 0x7fac1acea050; frame = (8 7; 2 19.5); userInteractionEnabled = NO; animations = { opacity=<CABasicAnimation: 0x7fac1dd511e0>; }; layer = <CALayer: 0x7fac1ace9ff0>>
   |    |    | <UIImageView: 0x7fac1f820340; frame = (0 31.5; 359 2.5); alpha = 0; opaque = NO; autoresize = TM; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1f820320>>
   |    |    | <UIImageView: 0x7fac1f820b50; frame = (318.5 -2; 2.5 36); alpha = 0; opaque = NO; autoresize = LM; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1f820b30>>
   |    | <UILabel: 0x7fac1d8d6eb0; frame = (367 5; 0 0); userInteractionEnabled = NO; layer = <_UILabelLayer: 0x7fac1d8d7010>>
   |    |    | <_UILabelContentLayer: 0x7fac1d8f8e60> (layer)
   |    | <UIImageView: 0x7fac1d8f8b60; frame = (0 -0.5; 375 0.5); autoresize = W+BM; userInteractionEnabled = NO; layer = <CALayer: 0x7fac1d8f8c60>>
   |    | <CALayer: 0x7fac1ac9a9c0> (layer)
   | <UIView: 0x7fac1dd79f60; frame = (0 64; 375 0); clipsToBounds = YES; layer = <CALayer: 0x7fac1de092e0>>

aryaxt · 2015-08-16T18:58:54Z

Maybe the SLKInputAccessoryView is covering the input bar?

- Dismiss the keyboard and the auto-completion view right after hiding the textInputBar - Fixes cases where hiding the textInputBar wouldn't be possible when the keyboard was up - Avoids hidding the textInputBar with alpha, instead fixed some auto-layout constraints so the textView would follow the dismissal animation

…nt animation duration anymore.

dzenbot · 2015-08-21T22:03:59Z

So far, this branch behaves great. I haven't found any apparent bugs. The one about auto-rotation seems fixed now.

@aryaxt Since the issue you're experiencing isn't related to this branch, let's open it in a new issue. I haven't been able to repro so far tho.

fyaqub · 2015-08-25T00:12:37Z

Source/Classes/SLKTextViewController.m

I like this block-based approach to handle the case with and without animations. Much cleaner than calling a separate method or duplicating the code.

Adds the ability to show/hide input bar. Closes #203. Closes #229

fyaqub · 2015-08-25T00:14:13Z

Awesome work guys!

aryaxt reviewed Aug 12, 2015
View reviewed changes

dzenbot changed the title ~~Adds the ability to show/hide input bar. Closes #203~~ Adds the ability to show/hide input bar. Closes #203. Closes #209 Aug 13, 2015

dzenbot changed the title ~~Adds the ability to show/hide input bar. Closes #203. Closes #209~~ Adds the ability to show/hide input bar. Closes #203. Closes #229 Aug 13, 2015

dzenbot added the new feature label Aug 13, 2015

aryaxt and others added 4 commits August 21, 2015 18:39

Added ability to show/hide input bar #203

af5ff15

Calling layout on view instead of textInputBar for smoother animations

50f38de

Makes sure to never set textInputbar hidden twice. No need to differe…

413f002

…nt animation duration anymore.

dzenbot force-pushed the aryaxt-master branch from 3807019 to 73d7c0e Compare August 21, 2015 22:05

Code style fix

73d7c0e

dzenbot added the needs testing label Aug 24, 2015

ignacio added 2 commits August 24, 2015 19:10

Fixes not being able to set the text inputbar hidden from viewDidLoad

6cc4a5e

Disables text edition if the textInputbar is hidden

6995b95

fyaqub reviewed Aug 25, 2015
View reviewed changes

fyaqub added a commit that referenced this pull request Aug 25, 2015

Merge pull request #230 from slackhq/aryaxt-master

5a44225

Adds the ability to show/hide input bar. Closes #203. Closes #229

fyaqub merged commit 5a44225 into master Aug 25, 2015

fyaqub deleted the aryaxt-master branch August 25, 2015 00:15

fluidsonic mentioned this pull request Aug 25, 2015

Input Bar hidden by Input Accessory View #243

Closed

giginet mentioned this pull request Jul 17, 2016

Add Carthage to .gitignore #493

Merged

6 tasks

acandelaria1 mentioned this pull request Sep 16, 2016

Changed all other calls of cache textView #514

Merged

This was referenced Sep 3, 2017

Fixed placeholder label layout - it should calculate bounds consideri… efremidze/SlackTextViewController#4

Merged

Fixed placeholder label layout - it should calculate bounds considering label width, not bounds width #617

Open

richlong mentioned this pull request Sep 11, 2017

604 unable to select textview Bipsync/SlackTextViewController#1

Merged

6 tasks

laeroah mentioned this pull request Sep 18, 2017

Fixed the iOS11 break of the library #621

Closed

6 tasks

say33m mentioned this pull request Oct 9, 2017

Update to iOS 11 heysphere/SlackTextViewController#1

Merged

6 tasks

josepbordesjove mentioned this pull request Oct 16, 2017

Feature/i phone x #635

Closed

6 tasks

This was referenced Nov 6, 2017

3.0.0 #649

Closed

Update bottom margin to accommodate iPhone X home indicator heysphere/SlackTextViewController#2

Closed

say33m mentioned this pull request Nov 28, 2017

Feature/second left button heysphere/SlackTextViewController#3

Merged

6 tasks

sabrinaip mentioned this pull request Dec 14, 2017

add bug fix for UIToolbarContentView for iOS 11.2 schun93/SlackTextViewController#1

Merged

6 tasks

blainerothrock mentioned this pull request Feb 20, 2018

Blaine/manual right button animation #663

Closed

6 tasks

amyleecodes mentioned this pull request Sep 12, 2018

iPhone X support 52inc/SlackTextViewController#1

Closed

6 tasks

tin612 mentioned this pull request Sep 21, 2018

merge keyboard panning tin612/SlackTextViewController#1

Merged

6 tasks

akaralar mentioned this pull request Nov 22, 2018

Sync with fork akaralar/SlackTextViewController#1

Merged

6 tasks

cuong1112035 mentioned this pull request Nov 26, 2018

increase touch area of send message button tin612/SlackTextViewController#2

Closed

6 tasks

roldy mentioned this pull request Sep 14, 2019

NPORAD-1298: alter tab bar button constraints to increase touch hot spots egeniq-forks/SlackTextViewController#3

Merged

6 tasks

michalciurus mentioned this pull request Sep 28, 2019

mm SparTechnologyCorp/SlackTextViewController#1

Merged

6 tasks

hvsw mentioned this pull request Dec 3, 2021

LIVE-225: Add left button image and text support untitledstartup/SlackTextViewController#1

Merged

hvsw mentioned this pull request Mar 16, 2022

Fix build error for physical devices. untitledstartup/SlackTextViewController#3

Merged

jramirez-allhealth mentioned this pull request Jul 1, 2022

[AS-4349] [iOS] Create new user interface for text view, attachments and audio record JawboneHealth/SlackTextViewController#1

Draft

6 tasks

diegodossantos95 mentioned this pull request Apr 17, 2023

CONT-5313: Expose slk_enableTypingSuggestionIfNeeded in the header to be overridable untitledstartup/SlackTextViewController#4

Merged

Adds the ability to show/hide input bar. Closes #203. Closes #229 #230

Adds the ability to show/hide input bar. Closes #203. Closes #229 #230

Uh oh!

Conversation

dzenbot commented Aug 12, 2015

Uh oh!

aryaxt Aug 12, 2015

Choose a reason for hiding this comment

Uh oh!

dzenbot Aug 12, 2015

Choose a reason for hiding this comment

Uh oh!

dzenbot Aug 12, 2015

Choose a reason for hiding this comment

Uh oh!

aryaxt commented Aug 12, 2015

Uh oh!

aryaxt commented Aug 13, 2015

Uh oh!

dzenbot commented Aug 13, 2015

Uh oh!

aryaxt commented Aug 13, 2015

Uh oh!

dzenbot commented Aug 13, 2015

Uh oh!

aryaxt commented Aug 13, 2015

Uh oh!

aryaxt commented Aug 16, 2015

Uh oh!

aryaxt commented Aug 16, 2015

Uh oh!

dzenbot commented Aug 21, 2015

Uh oh!

fyaqub Aug 25, 2015

Choose a reason for hiding this comment

Uh oh!

fyaqub commented Aug 25, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants