Skip to content
This repository was archived by the owner on Aug 5, 2019. It is now read-only.

Conversation

@say33m
Copy link

@say33m say33m commented Oct 9, 2017

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

e.g. New functionality for producing whatsits.

Related Issues

e.g. Fixes slackhq#206 and closes slackhq#230

Test strategy

e.g. Add tests around whatsit production.

@say33m say33m merged commit 640b52c into master Oct 9, 2017
@say33m say33m deleted the iOS-11-fork branch November 28, 2017 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The function numberOfLines in SLKTextView did not calculate correct?

2 participants