Skip to content
This repository was archived by the owner on Oct 30, 2018. It is now read-only.

Conversation

@blainerothrock
Copy link

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've added a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • I've listed my changes on the [Changelog(https://github.com/slackhq/SlackTextViewController/blob/master/CHANGELOG.md) file.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

e.g. New functionality for producing whatsits.

Related Issues

e.g. Fixes #206 and closes #230

Test strategy

e.g. Add tests around whatsit production.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The function numberOfLines in SLKTextView did not calculate correct?

4 participants