Scapy v2.4.3

[gpotter2]

We need to make a 2.4.3 quite soon, as we're getting tons of reports of the *BSD bug & the missing LICENSE bug (#1864, #1862, #1796, #1793, #1783): See 2.4.3rc1 (which isn't really an rc..)

Among the opened PRs, here are the one I'd like to see included, before the release (it's fine if it's not included in the rc):

• Drop distutils - cleanup scapy executables #1869 (Drop distutils + cleanup executables)
• Add text wireshark support #1848 (that's something scapy3k was bragging about, except we make a 2-line version of tdecode thanks to @p-l- tip)
• Cleanup DNS decompression + fix warning messages being shown #1849 (it fixes a quite bad regression of the DNS module + cleans it up)
• Scapy docs massive cleanup #1865 (doc + log fixes)
• Fix various memory leaks when receiving packets #1847 (the latency thing + doc cleanup)
• Fix FCSField computation on already dissected packet #1884 (quite critical 802.11 fix)
• (potentially) CCP protocol implementation #1858 if they manage to finish the PR in time
• generally all Automative-related bug fixes, to make sure we have something stable for their first appearances
• Fix MultipleTypeField default values handling #1994: fix MultipleTypeField
• Check if tcpdump binary exists #1934: Fox tcpdump detection
• DNS cleanup & various cleanups #1968 : cleanup the DNS implementation
• Send IP packet on OpenBSD Loopback with correct address family. #1907: fix Loopback on OpenBSD
• Fix dissection of TLS communication with NULL Cipher. #1986 : a TLS dissection issue
• Console & Config improvement #1996: nice console improvements
• Workaround tcpdump lack of -y <integer> support #2005: fix tshark/tcpdump handling of linktype
• Monitor mode docs #2028: remove over-restricting rule in monitor mode & doc
• Improve path detection & Add backup ethertypes #2011: Fix Ethertypes
• Fix FlagsField & dissection improvements #2035: +5-10% dissection speed
• Sendrecv overhaul: async sniffing & major cleanup #1999: Asynchronous sniffing
• Drop pcapy-like integrations in favor of winpcapy.py (no acitivity) #2057: drop dependencies for libpcap Python bindings
• Backward compatibility: Add Deprecated fields #1983: Backward compatibility fields
• Remove duplicated code #2105: remove duplicated code
• Fix race conditions on Init #2102: fix race conditions
• Linux 802.1Q support #2091: support 802.1Q natively on linux
• Smarter interface selection when sending one packet #2108: smarted interface selection with high level commends (sr suite)
• Add TLS 1.3 support (basic) #2146: TLS 1.3 overhaul

Non blocking but cool:

• Implement HTTP 1.0 & fix TCP_client #1925: HTTP 1.0

[guedou]

I can do a v2.4.3rc1 on Tuesday and submit it to pypi with the current master. That will fix the main issues and leave more time to fix the other problems.

[guedou]

I did not see your answer earlier. A test failed locally, I will submit a PR.

I had to disable the ISOTP unit tests, using:

tox -- -T scapy/contrib/isotp.uts

@polybassa do you think that it is possible to implement a check that will disable ISOTP unit tests automatically when the mandatory requirements are not installed?

[guedou]

Other tests related to the TLS Automaton are also faling locally.

[polybassa]

Hi, @epozzobon implemented a similar behaviour here:

scapy/scapy/contrib/isotp.uts

Line 65 in c1ee9d0

def exit_if_no_isotp_module():

I think, we can extend this check to all ISOTPSocket related unit-tests.

[polybassa]

@guedou What tests did fail for you, locally?

[guedou]

@polybassa the first failing test is
failed 046BF42D Test sniffer with multiple frames

then this one and the following tests:
failed 4953DB12 Verify that packets are not lost if they arrive before the sniff() is called

[guedou]

On Ubuntu 18.10, linux_warnings fails as well as some tests in isotp.uts. Everything else is OK.

[polybassa]

Thanks for this information. I'll create a PR for this. How urgent is this problem? Can it wait a week?