Skip to content

Conversation

guedou
Copy link
Member

@guedou guedou commented Jun 25, 2019

Attempt at removing useless code and increasing the coverage.

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #2105 into master will increase coverage by 0.01%.
The diff coverage is 87.87%.

@@            Coverage Diff             @@
##           master    #2105      +/-   ##
==========================================
+ Coverage    87.2%   87.21%   +0.01%     
==========================================
  Files         197      197              
  Lines       44506    44498       -8     
==========================================
+ Hits        38810    38811       +1     
+ Misses       5696     5687       -9
Impacted Files Coverage Δ
scapy/layers/ppp.py 97.1% <100%> (ø) ⬆️
scapy/layers/sctp.py 96.68% <100%> (ø) ⬆️
scapy/layers/dhcp6.py 85.73% <63.63%> (+0.6%) ⬆️
scapy/automaton.py 85.98% <0%> (+0.54%) ⬆️

@guedou guedou force-pushed the codacy_duplicated_code branch 2 times, most recently from d066d11 to 361aef1 Compare June 26, 2019 13:54
@gpotter2 gpotter2 added the cleanup Performs some code clean-up label Jun 26, 2019
@guedou guedou force-pushed the codacy_duplicated_code branch from 361aef1 to c16c22a Compare June 27, 2019 11:20
@gpotter2 gpotter2 mentioned this pull request Jun 29, 2019
27 tasks
@guedou guedou force-pushed the codacy_duplicated_code branch from c16c22a to 3219b8a Compare July 1, 2019 10:18
@guedou
Copy link
Member Author

guedou commented Jul 1, 2019

@gpotter2 ready ti be merged

@gpotter2 gpotter2 merged commit fba56ae into secdev:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Performs some code clean-up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants