Scapy all import fails on FreeBSD

[ykvch]

scapy version initially reproduced: 2.4.1
OS: FreeBSD 12

Steps:

1. Run code from scapy.all import *

Expected:

1. Modules imported

Actual:
Exception:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/user/venv/lib/python3.6/site-packages/scapy/all.py", line 18, in <module>
    from scapy.arch import *
  File "/home/user/venv/lib/python3.6/site-packages/scapy/arch/__init__.py", line 63, in <module>
    conf.use_bpf = True
  File "/home/user/venv/lib/python3.6/site-packages/scapy/config.py", line 75, in __set__
    self.hook(self.name, val, *self.args, **self.kargs)
  File "/home/user/venv/lib/python3.6/site-packages/scapy/config.py", line 491, in _socket_changer
    _set_conf_sockets()
  File "/home/user/venv/lib/python3.6/site-packages/scapy/config.py", line 436, in _set_conf_sockets
    raise ScapyInvalidPlatformException("Darwin (OSX) only !")
scapy.error.ScapyInvalidPlatformException: Darwin (OSX) only !

Note: probably caused by check here:
https://github.com/secdev/scapy/blob/v2.4.1/scapy/config.py#L434
Which appears to assume that BPF is exclusively used on OSX.
Note: FreeBSD (not sure about other *BSD OSes) also uses /dev/bpf

[gpotter2]

Totally my fault :/ sorry for the inconvenience

Caused by
22a92a8

@guedou Sorry for that, we’ll probably also have to do 2.4.3... I’m looking for a way to add *BSD tests

[guedou]

There is no easy way. I used vagrant a lot while developping the BPF sockets.

I will try to come up with a release checklist over the weekend.

[ykvch]

Since most bsd-like seem to have similar bpf behaviour
My quick guess would be a patch like this:

diff --git a/scapy/config.py b/scapy/config.py
index 7df2bdf0..12b221ab 100755
--- a/scapy/config.py
+++ b/scapy/config.py
@@ -16,7 +16,7 @@ import socket
 import sys
 
 from scapy import VERSION, base_classes
-from scapy.consts import DARWIN, WINDOWS, LINUX
+from scapy.consts import DARWIN, WINDOWS, LINUX, BSD
 from scapy.data import ETHER_TYPES, IP_PROTOS, TCP_SERVICES, UDP_SERVICES, \
     MANUFDB
 from scapy.error import log_scapy, warning, ScapyInvalidPlatformException
@@ -431,9 +431,9 @@ def _set_conf_sockets():
     """Populate the conf.L2Socket and conf.L3Socket
     according to the various use_* parameters
     """
-    if conf.use_bpf and not DARWIN:
+    if conf.use_bpf and not BSD:
         Interceptor.set_from_hook(conf, "use_bpf", False)
-        raise ScapyInvalidPlatformException("Darwin (OSX) only !")
+        raise ScapyInvalidPlatformException("BSD-like (OSX) only !")
     if conf.use_winpcapy and not WINDOWS:
         Interceptor.set_from_hook(conf, "use_winpcapy", False)
         raise ScapyInvalidPlatformException("Windows only !")

Have to test it though. Possibly there's more than just one check in that logic.