Various cleanups around opaque types #90376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't do member constraint checks in regionck anymore. All member constraint checks are done in mir borrowck.
They don't depend on trait selection anymore, so there is no need for an extension trait.
It does not depend on anything from rustc_trait_selection anymore.
oli-obk
added
the
C-cleanup
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Cool! |
spastorino
approved these changes
Oct 28, 2021
|
@bors r+ |
|
📌 Commit bc552fc has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup=always |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 28, 2021
…askrgr Rollup of 3 pull requests Successful merges: - rust-lang#90082 (Fix minor typos) - rust-lang#90336 (Remove extra lines in examples for `Duration::try_from_secs_*`) - rust-lang#90376 (Various cleanups around opaque types) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit by commit.
This PR has no functional changes.
Mostly it's moving logic from an extension trait in rustc_trait_selection to inherent impls on rustc_infer.