Rollup of 3 pull requests #90387
Rollup of 3 pull requests #90387
Conversation
We don't do member constraint checks in regionck anymore. All member constraint checks are done in mir borrowck.
They don't depend on trait selection anymore, so there is no need for an extension trait.
It does not depend on anything from rustc_trait_selection anymore.
Remove extra lines in examples for `Duration::try_from_secs_*` None of the other examples have extra lines below the `#![feature(...)]` statements, so I thought it appropriate that these examples shouldn't either.
Various cleanups around opaque types Best reviewed commit by commit. This PR has no functional changes. Mostly it's moving logic from an extension trait in rustc_trait_selection to inherent impls on rustc_infer.
|
@bors r+ p=3 rollup=never |
|
📌 Commit bcee0a6 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (df76418): comparison url. Summary: This change led to large relevant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression |
|
Given the list of PR's on this rollup, it seems like PR #90376 is the most likely source of the regression detected in previous comment. |
|
inflate regressed by 1.2-2.4% in various contexts. All other regressions were less than 1%. based on manual review of PR #90376, I'm willing to believe that the performance change here is due to code memory alignment artifacts that can be caused by code rearrangement. @rustbot label: +perf-regression-triaged |
rustbot
added
the
perf-regression-triaged
Successful merges:
Duration::try_from_secs_*#90336 (Remove extra lines in examples forDuration::try_from_secs_*)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup