Rollup of 6 pull requests #28798
Closed
Rollup of 6 pull requests #28798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Oct 1, 2015
steveklabnik
commented
- Successful merges: E0422 description. #28554, Don't crash on non-existent path in constant. #28686, Add link to Florian Wilkens's Bachelor's Thesis #28786, doc: fix swapped docs for intro_ptr and intro_raw of CString #28788, Add test for #25439 #28791, Rebase for gankro #28797
- Failed merges:
|
@bors: r+ rollup |
|
📌 Commit db27dca has been approved by |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit db27dca has been approved by |
|
@bors: rollup- |
|
💔 Test failed - auto-linux-64-opt |
Previously only keyup event was looked at, which meant that pasting, cutting and otherwise changing the input without typing would not catch any updates to the search query.
It's not really clear here, since the example is rendered, where it starts and ends. So let's use <hr>s to split it up.
Our docs were very basic for the various versions of from_utf8, so this commit beefs them up. It also improves docs for the &str variant's error, Utf8Error.
…docs, r=brson Our docs were very basic for the various versions of from_utf8, so this commit beefs them up. It also improves docs for the &str variant's error, Utf8Error.
The list was grabled. r? @steveklabnik
It's not really clear here, since the example is rendered, where it starts and ends. So let's use <hr>s to split it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.