Improve documentation for the from_utf8 family #28812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
r=me |
steveklabnik
force-pushed
the
improve_str_from_utf8_docs
branch
from
13cf156 to
f6a8b06
Compare
|
@bors: r=brson rollup |
|
📌 Commit f6a8b06 has been approved by |
| /// (`&[u8]`) is made of bytes, so this function converts between the two. | ||
| /// Not all byte slices are valid string slices, however: `&str` requires | ||
| /// that it is valid UTF-8. During this conversion, `from_utf8_lossy()` | ||
| /// will replace any invalid UTF-8 sequences are replaced with |
There was a problem hiding this comment.
"will replace any invalid UTF-8 sequences are replaced with".
steveklabnik
force-pushed
the
improve_str_from_utf8_docs
branch
from
f6a8b06 to
4d73da9
Compare
|
@bors: r=brson rollup |
|
📌 Commit 4d73da9 has been approved by |
Our docs were very basic for the various versions of from_utf8, so this commit beefs them up. It also improves docs for the &str variant's error, Utf8Error.
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Oct 3, 2015
…docs, r=brson Our docs were very basic for the various versions of from_utf8, so this commit beefs them up. It also improves docs for the &str variant's error, Utf8Error.
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Oct 3, 2015
…docs, r=brson Our docs were very basic for the various versions of from_utf8, so this commit beefs them up. It also improves docs for the &str variant's error, Utf8Error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our docs were very basic for the various versions of from_utf8, so
this commit beefs them up.
It also improves docs for the &str variant's error, Utf8Error.