Remove footer #2013
Merged
Remove footer #2013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
|
This is a great idea! |
Move "About" and "Privacy policy" into the Rust menu. The footer required a lot of workarounds to work with the various bits of HTML that rustdoc (and doc authors!) generated. It's hard enough to make the topbar work consistently; adding a footer to nearly-arbitrary HTML is too much, particularly when we can achieve the same thing in the topbar.
GuillaumeGomez
approved these changes
Jan 22, 2023
|
It'll make things so much simpler! |
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move "About" and "Privacy policy" into the Rust menu.
The footer required a lot of workarounds to work with the various bits of HTML that rustdoc (and doc authors!) generated. It's hard enough to make the topbar work consistently; adding a footer to nearly-arbitrary HTML is too much, particularly when we can achieve the same thing in the topbar.
Fixes #1775.