Skip to content

Remove footer #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions templates/base.html
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@
{%- block header %}{% endblock header -%}

{%- block body -%}{%- endblock body -%}
{%- include "footer.html" -%}


{%- block javascript -%}{%- endblock javascript -%}
</body>
Expand Down
5 changes: 0 additions & 5 deletions templates/footer.html

This file was deleted.

10 changes: 10 additions & 0 deletions templates/header/topbar_end.html
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,16 @@
#}<li class="pure-menu-item pure-menu-has-children">
<a href="#" class="pure-menu-link" aria-label="Rust">Rust</a>
<ul class="pure-menu-children">
{{ macros::menu_link(
href="https://docs.rs/about",
text="About docs.rs",
target="_blank"
) }}
{{ macros::menu_link(
href="https://foundation.rust-lang.org/policies/privacy-policy/#docs.rs",
text="Privacy policy",
target="_blank"
) }}
{{ macros::menu_link(
href="https://www.rust-lang.org/",
text="Rust website",
Expand Down
1 change: 0 additions & 1 deletion templates/rustdoc/body.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@
<script type="text/javascript" src="/-/static/index.js?{{ docsrs_version() | slugify }}"></script>
{# see comment in ../storage-change-detection.html for details #}
<iframe loading="lazy" src="/-/storage-change-detection.html" width="0" height="0" style="display: none"></iframe>
{%- include "footer.html" -%}
30 changes: 0 additions & 30 deletions templates/style/_footer.scss

This file was deleted.

29 changes: 1 addition & 28 deletions templates/style/_rustdoc-common.scss
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
// FIXME: Use modules
@import "vars", "navbar", "themes", "fa", "footer";

// This rule is needed to be sure that the footer will always be at the bottom of the page.
#rustdoc_body_wrapper {
min-height: calc(100vh - #{$footer-height + 2});
}
@import "vars", "navbar", "themes", "fa";

#clipboard {
cursor: pointer;
Expand All @@ -17,34 +12,12 @@ body.rustdoc-page > .nav-container > .container {

div.container-rustdoc {
text-align: left;

> .docs-rs-footer {
width: unset;
}
}

div.container-rustdoc {
width: unset;
}

div.container-rustdoc:not(.source) {
// This is when the rustdoc sidebar "disappears" (for mobile mode).
@media (max-width: 700px) {
> .docs-rs-footer:not(.source) {
left: -15px;
}
}
}

div.container-rustdoc {
> .docs-rs-footer {
left: -15px;
// This is needed because even though the sidebar only contains the header, it still takes
// all the height, going over the footer.
z-index: 1;
}
}

// this is a super nasty override for help dialog in rustdocs
// see #52 for details
body.blur {
Expand Down
1 change: 0 additions & 1 deletion templates/style/_vars.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ $font-family-mono: "Source Code Pro", Menlo, Monaco, Consolas, "DejaVu Sans Mono

// Sizes
$top-navbar-height: 32px; // height of the floating top navbar
$footer-height: 30px; // height of the floating footer

// Pure compatible media queries
// usage:
Expand Down
13 changes: 0 additions & 13 deletions templates/style/rustdoc-2021-12-05.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,26 +13,13 @@
height: calc(100vh - #{$top-navbar-height});
/* Since we use `overflow-wrap: anywhere;`, we never have the need for a X scrollbar... */
overflow-x: hidden;

.sidebar-menu {
top: $top-navbar-height;
margin-bottom: $footer-height;
}
}

main {
padding-bottom: 50px;
}
}

div.container-rustdoc {
> .docs-rs-footer {
bottom: 0;
right: 0;
left: 0;
}
}

@media (max-width: 700px) {
.source main {
height: auto;
Expand Down
11 changes: 0 additions & 11 deletions templates/style/rustdoc.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,9 @@

div.container-rustdoc {
text-align: left;

> .docs-rs-footer {
bottom: -32px;
right: -15px;
}
}


div.container-rustdoc:not(.source) {
> .docs-rs-footer {
left: 185px; // This is the left sidebar
}
}

div.rustdoc {
#sidebar-toggle {
top: 62px;
Expand Down
11 changes: 1 addition & 10 deletions templates/style/style.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// FIXME: Use modules
@import "vars", "utils", "navbar", "themes", "fa", "footer", "syntax";
@import "vars", "utils", "navbar", "themes", "fa", "syntax";

/* See FiraSans-LICENSE.txt for the Fira Sans license. */
@font-face {
Expand Down Expand Up @@ -197,10 +197,6 @@ body {
g.highcharts-grid > path {
stroke: var(--chart-grid) !important;
}

> .about-page {
padding-bottom: calc(#{$footer-height} + 2px);
}
}

pre {
Expand All @@ -213,11 +209,6 @@ div.container {
max-width: 1160px;
margin: 0 auto;
text-align: left;

> .chartjs-render-monitor {
// This is to prevent the canvas text to go under the footer.
padding-bottom: 35px;
}
}

div.landing {
Expand Down