Skip to content

remove footer; change Rust menu to "About" #1775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsha opened this issue Jul 21, 2022 · 6 comments · Fixed by #2013
Closed

remove footer; change Rust menu to "About" #1775

jsha opened this issue Jul 21, 2022 · 6 comments · Fixed by #2013

Comments

@jsha
Copy link
Contributor

jsha commented Jul 21, 2022

Right now docs.rs adds a footer as well as a header to each page. This is a frequent source of layout bugs, as it interacts in a complicated way with rustdoc's CSS. It contains:

I propose that we eliminate the footer, and move these links to the topbar. If we rename the "Rust" menu to "About", I think they would fit well there. This would also make them more visible and easier to reach. I think many people never notice the footer all the way at the bottom of the page (I didn't for years, until I saw a bug report about it :-D).

@jyn514
Copy link
Member

jyn514 commented Jul 21, 2022

I think many people never notice the footer all the way at the bottom of the page (I didn't for years, until I saw a bug report about it :-D).

we actually added it fairly recently (~10 months ago?). I don't feel strongly about it, happy to move to the header instead.
cc @pietroalbini who added the footer

@pietroalbini
Copy link
Member

I'm not sure if putting them in a dropdown is going to make them more visible, and my intuition would say the opposite (still, I'm not that good at UI/UX). The only thing I think is critical to have visible in the page is the privacy policy link, but having it as an item (outside the dropdown) in the header feels excessive.

(btw I'm pretty sure I wasn't the one adding the footer?)

@syphar
Copy link
Member

syphar commented Jul 24, 2022

for the record: initial PR was #1367

@jsha
Copy link
Contributor Author

jsha commented Jul 24, 2022 via email

@pietroalbini
Copy link
Member

That's my understanding, but I'm not a lawyer and I'm probably wrong. We should check with the foundation about it.

@jsha
Copy link
Contributor Author

jsha commented Dec 5, 2022

I checked with the foundation, via our community advocate @sgrif, and got feedback from a lawyer that it is fine to put in the header. 👍🏻

Edit: specifically, that it is fine to put in a menu in the header.

@jsha jsha mentioned this issue Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants