mirage: Use relationship system #2137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit d1210db has been approved by |
bors
added a commit
that referenced
this pull request
Jan 15, 2020
mirage: Use relationship system see https://www.ember-cli-mirage.com/docs/data-layer/relationships Until now we've been keeping track of the relationships between the mirage resources manually, but mirage has a built-in relationship system for this that can simplify the code quite a bit when used correctly. This PR is replacing this manual tracking with declarative relationships. r? @locks
Turbo87
force-pushed
the
relationships
branch
from
17ab337 to
bf34146
Compare
|
📌 Commit bf34146 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 16, 2020
mirage: Use relationship system see https://www.ember-cli-mirage.com/docs/data-layer/relationships Until now we've been keeping track of the relationships between the mirage resources manually, but mirage has a built-in relationship system for this that can simplify the code quite a bit when used correctly. This PR is replacing this manual tracking with declarative relationships. r? @locks
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit bf34146 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 16, 2020
mirage: Use relationship system see https://www.ember-cli-mirage.com/docs/data-layer/relationships Until now we've been keeping track of the relationships between the mirage resources manually, but mirage has a built-in relationship system for this that can simplify the code quite a bit when used correctly. This PR is replacing this manual tracking with declarative relationships. r? @locks
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://www.ember-cli-mirage.com/docs/data-layer/relationships
Until now we've been keeping track of the relationships between the mirage resources manually, but mirage has a built-in relationship system for this that can simplify the code quite a bit when used correctly. This PR is replacing this manual tracking with declarative relationships.
r? @locks