Skip to content

A new warning when running npm test #2156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jtgeibel opened this issue Jan 24, 2020 · 1 comment · Fixed by #2407
Closed

A new warning when running npm test #2156

jtgeibel opened this issue Jan 24, 2020 · 1 comment · Fixed by #2407
Labels
A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Comments

@jtgeibel
Copy link
Member

When running npm test I'm seeing the following warning for several tests:

ok 31 Chrome 79.0 - [1159 ms] - Acceptance | crates page: /crates is accessible
    ---
        browser log: |
            WARN: ember-moment: an empty value (null, undefined, or "") was passed to ember-moment helper
            WARN: ember-moment: an empty value (null, undefined, or "") was passed to ember-moment helper
            WARN: ember-moment: an empty value (null, undefined, or "") was passed to ember-moment helper
            WARN: ember-moment: an empty value (null, undefined, or "") was passed to ember-moment helper
            WARN: ember-moment: an empty value (null, undefined, or "") was passed to ember-moment helper
            WARN: ember-moment: an empty value (null, undefined, or "") was passed to ember-moment helper
            WARN: ember-moment: an empty value (null, undefined, or "") was passed to ember-moment helper
            WARN: ember-moment: an empty value (null, undefined, or "") was passed to ember-moment helper
    ...

I've checked a few CI logs and think this was introduced in #2137. cc @Turbo87

@Turbo87
Copy link
Member

Turbo87 commented Jan 24, 2020

yeah, that is very likely. ultimately my goal is to replace the inconsistent static test fixtures with a setup using mirage factories, which should fix this issue. unfortunately I won't have time to work on it again until next week though 😞

@bors bors closed this as completed in 6681d63 Apr 10, 2020
@Turbo87 Turbo87 added the C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear label Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants