Auto merge of #2137 - Turbo87:relationships, r=locks

mirage: Use relationship system

see https://www.ember-cli-mirage.com/docs/data-layer/relationships

Until now we've been keeping track of the relationships between the mirage resources manually, but mirage has a built-in relationship system for this that can simplify the code quite a bit when used correctly. This PR is replacing this manual tracking with declarative relationships.

r? @locks

Author: bors

mirage/factories/crate.js

@@ -23,10 +23,5 @@ export default Factory.extend({
   updated_at: '2017-02-24T12:34:56Z',
 
   badges: () => [],
-  categories: () => [],
-  keywords: () => [],
-  versions: () => [],
   _extra_downloads: () => [],
-  _owner_teams: () => [],
-  _owner_users: () => [],
 });

mirage/factories/dependency.js

@@ -3,13 +3,19 @@ import { Factory } from 'ember-cli-mirage';
 const REQS = ['^0.1.0', '^2.1.3', '0.3.7', '~5.2.12'];
 
 export default Factory.extend({
-  // crate_id,
-  // version_id,
-
   default_features: i => i % 4 === 3,
   features: () => [],
   kind: i => (i % 3 === 0 ? 'dev' : 'normal'),
   optional: i => i % 4 !== 3,
   req: i => REQS[i % REQS.length],
   target: null,
+
+  afterCreate(self) {
+    if (!self.crateId) {
+      throw new Error(`Missing \`crate\` relationship on \`dependency:${self.id}\``);
+    }
+    if (!self.versionId) {
+      throw new Error(`Missing \`version\` relationship on \`dependency:${self.id}\``);
+    }
+  },
 });

mirage/factories/version-download.js

@@ -1,8 +1,12 @@
 import { Factory } from 'ember-cli-mirage';
 
 export default Factory.extend({
-  // version
-
   date: '2019-05-21',
   downloads: i => (((i * 42) % 13) + 4) * 2345,
+
+  afterCreate(self) {
+    if (!self.versionId) {
+      throw new Error(`Missing \`version\` relationship on \`version-download:${self.date}\``);
+    }
+  },
 });

mirage/factories/version.js

@@ -11,19 +11,16 @@ export default Factory.extend({
   yanked: false,
   license: i => LICENSES[i % LICENSES.length],
 
-  dl_path() {
-    return `/api/v1/crates/${this.crate}/${this.num}/download`;
-  },
-
   downloads: i => (((i + 13) * 42) % 13) * 1234,
 
   features: () => {},
   _authors: () => [],
 
   crate_size: i => (((i + 13) * 42) % 13) * 54321,
 
-  afterCreate(version, server) {
-    let crate = server.schema.crates.find(version.crate);
-    crate.update({ versions: crate.versions.concat(parseInt(version.id, 10)) });
+  afterCreate(version) {
+    if (!version.crateId) {
+      throw new Error(`Missing \`crate\` relationship on \`version:${version.num}\``);
+    }
   },
 });