[fixed] keep references of modals when available. #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add linting * Make specs pass linter * Make lib/helpers pass linter * Make lib/components pass linter This also does some signfiicant refactoring of the code to appease the linter's pro-ES2015+ stance. closes reactjs#289 closes reactjs#286 * Make travis run the lint task as well as specs closes reactjs#284
* [fixed] Make use of es6 modules * [fixed] Fix `this` scope
* Add sauce labs testing info to karma This also removes Node versions 4, 5, 6 from Travis. The node version only matters for development not for use. I don't think it's a problem officially supporting only the latest node for development. * Make specs work under IE 11
this PR allow a stack of modals to give back focus to parent modal.
keeping a reference of all modals in order to manage when to add/remove classes and aria from elements correctly.
diasbruno
force-pushed
the
fix/modal-reference-count
branch
from
55fac94 to
09880af
Compare
diasbruno
changed the title
5 tasks
|
Hi @diasbruno, I've taken your tests from this PR and proposed an alternative solution here: #328 Please let me know if you have any questions or if I'm missing a case we should be testing for 😸 |
|
@ajfuller awesome. I'll check it. |
|
@diasbruno thanks for the heads up on this. Any idea when this update might land? |
|
can you resolve the branch conflict and submit this? |
|
@ChenRoth this needs to be ported to |
|
@diasbruno this hasn't been released yet has it? |
|
@boonier I'll try to write the backport to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keeping a reference of all modals in order to manage
when to add/remove classes and aria from elements
correctly.
solution based on @MarkMurphy's idea #308, but it uses a simple list
to work on IE (don't really support
Set).Fixes #218 #231 #308.
Acceptance Checklist:
CONTRIBUTING.md.