Skip to content

Fix an example #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 1, 2017
Merged

Fix an example #296

merged 2 commits into from
Jan 1, 2017

Conversation

hiroppy
Copy link
Contributor

@hiroppy hiroppy commented Jan 1, 2017

Changes proposed:

2017-01-01 19 58 27

We change to use es6 modules or rewrite it to `require('../../lib/index').defalut`.

I think it would be better to use es6 modules.

2017-01-01 19 59 04

Upgrade Path (for changed or removed APIs):

Acceptance Checklist:

  • All commits have been squashed to one.
  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

@coveralls
Copy link

coveralls commented Jan 1, 2017

Coverage Status

Coverage increased (+0.09%) to 76.753% when pulling 262e40d on abouthiroppy:fix/example into e10181d on reactjs:master.

@claydiffrient claydiffrient merged commit d50918c into reactjs:master Jan 1, 2017
@hiroppy hiroppy deleted the fix/example branch January 1, 2017 15:52
@diasbruno diasbruno mentioned this pull request Jun 14, 2017
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants