Modify the sample code to es2015 syntax in README.md #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var React = require('react'); | ||
| var ReactDOM = require('react-dom'); | ||
| var Modal = require('react-modal'); | ||
| const React = require('react'); |
There was a problem hiding this comment.
Should we go ahead and do import React from 'react'; here?
| @@ -155,7 +155,7 @@ const customStyles = { | |||
| }; | |||
|
|
|||
|
|
|||
| var App = React.createClass({ | |||
| const App = React.createClass({ | |||
There was a problem hiding this comment.
Perhaps convert this over to ES2015 class syntax as well?
There was a problem hiding this comment.
OK, so I'll change es2015 syntax :)
hiroppy
force-pushed
the
feature/update-readme
branch
from
eb842b5 to
088f844
Compare
|
@claydiffrient Updated. |
hiroppy
changed the title
var with const in README.md
hiroppy
changed the title
hiroppy
force-pushed
the
feature/update-readme
branch
from
088f844 to
647d31e
Compare
diasbruno
pushed a commit
to diasbruno/react-modal
that referenced
this pull request
Jun 14, 2017
diasbruno
pushed a commit
to diasbruno/react-modal
that referenced
this pull request
Jun 15, 2017
diasbruno
pushed a commit
to diasbruno/react-modal
that referenced
this pull request
Jun 15, 2017
diasbruno
pushed a commit
that referenced
this pull request
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
We use
constin README.md's sample.Upgrade Path (for changed or removed APIs):
Acceptance Checklist:
CONTRIBUTING.md.