If 2 or more modals are open and one is closed, `ReactModal__Body--open` class is erroneously removed

[ameyms]

Summary:

If two or more modals are open and one is closed, ReactModal__Body--open class is erroneously removed from body element

Steps to reproduce:

1. Open a modal M1
2. Open a second modal M2
3. Close M2. The class ReactModal__Body--open will no longer exist on body element.

Expected behavior:

The class ReactModal__Body--open should be active on the body element as long as there is at least one instance of modal open

Additional notes:

Perhaps we need to keep track of the total number of open modal instances?

react-modal/lib/components/Modal.js

Lines 66 to 73 in 6550b87

	elementClass(document.body).remove('ReactModal__Body--open');
	},
	renderPortal: function(props) {
	if (props.isOpen) {
	elementClass(document.body).add('ReactModal__Body--open');
	} else {
	elementClass(document.body).remove('ReactModal__Body--open');

[odensc]

I made a (bad) decorator to fix this, if it helps anyone: https://gist.github.com/odensc/b9ff804902d5ecc53d92caf8e81dea9b

[feibyte]

Even the demo still has this bug!

[iluminus]

Hi,

When do you expect this bug to be resolved?
I have the same issue and am waiting for the resolution before I upgrade to the latest version.

Thanks!

[claydiffrient]

@iluminus I'm pretty sure this should be solved on the 1.7.x release. Please give it a try and see if it works for you. If it does, we'll close this issue. I think it should be closed already, but I'll hold it open to get verification from you.

[iluminus]

@claydiffrient I checked and it works when installing your latest version.
Thank you!

[nickav]

I'm still experiencing this issue with multiple ReactModals on the page. The ReactModal__Body--open gets added and then immediately removed on page reload. Inspecting the dom then shows one ReactModalPortal with children that isOpen=true for.