-
Notifications
You must be signed in to change notification settings - Fork 4k
Add rabbitmq_cli dialyze to bazel (backport #7066) (backport #7114) #7122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add rabbitmq_cli dialyze to bazel and fix a number of warnings Because we stop mix from recompiling rabbit_common in bazel, many unknown functions are reported, so this dialyzer analysis is somewhat incomplete. * Use erlang dialyzer for rabbitmq_cli rather than mix dialyzer Since this resolves all of the rabbit functions, there are far fewer unknown functions. Requires yet to be released rules_erlang 3.9.2 * Temporarily use pre-release rules_erlang So that checks can run on this PR without a release * Fix additional dialyzer warnings in rabbitmq_cli * rabbitmq_cli: mix format * Additional fixes for ignored return values * Revert "Temporarily use pre-release rules_erlang" This reverts commit c16b5b6. * Use rules_erlang 3.9.2 (cherry picked from commit bdb2046) # Conflicts: # deps/rabbit_common/src/rabbit_misc.erl (cherry picked from commit 6be4463)
(cherry picked from commit 0dbbcf2)
Collaborator
|
This should wait until |
Collaborator
passes for me locally on Erlang 24.3. |
Contributor
|
The buildbuddy logs indicate additional errors for erlang 24 only. I will have a go at fixing them. |
HoloRin
added a commit
that referenced
this pull request
Feb 1, 2023
570ab50 to
624394e
Compare
HoloRin
added a commit
that referenced
this pull request
Feb 1, 2023
michaelklishin
added a commit
that referenced
this pull request
Feb 2, 2023
Forward-port dialyzer related rabbitmq_cli fixes from #7122
mergify bot
pushed a commit
that referenced
this pull request
Feb 2, 2023
(cherry picked from commit 0ac62a4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #7114 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com