Additional dialyzer related adjustments in rabbitmq_cli

Author: HoloRin

deps/rabbitmq_cli/lib/rabbitmq/cli/auto_complete.ex

@@ -10,6 +10,8 @@ defmodule RabbitMQ.CLI.AutoComplete do
   # Use the same jaro distance limit as in Elixir's "did you mean?"
   @jaro_distance_limit 0.77
 
+  @dialyzer :no_unused
+
   @spec complete(String.t(), [String.t()]) :: [String.t()]
   def complete(_, []) do
     []

deps/rabbitmq_cli/lib/rabbitmq/cli/core/parser.ex

@@ -8,6 +8,8 @@ defmodule RabbitMQ.CLI.Core.Parser do
   alias RabbitMQ.CLI.{CommandBehaviour, FormatterBehaviour}
   alias RabbitMQ.CLI.Core.{CommandModules, Config, Helpers}
 
+  @dialyzer [:no_unused, :no_return]
+
   def default_switches() do
     [
       node: :string,

deps/rabbitmq_cli/lib/rabbitmqctl.ex

@@ -18,17 +18,20 @@ defmodule RabbitMQCtl do
   alias RabbitMQ.CLI.{CommandBehaviour, FormatterBehaviour}
   alias RabbitMQ.CLI.Ctl.Commands.HelpCommand
 
+  @dialyzer [
+    {:no_unused, normalise_options: 1},
+    {:no_unused, normalise_timeout: 1},
+    {:nowarn_function, output_device: 1},
+    {:nowarn_function, handle_shutdown: 1}
+  ]
+
   # Enable unit tests for private functions
   @compile if Mix.env() == :test, do: :export_all
 
   @type options() :: map()
   @type command_result() :: {:error, ExitCodes.exit_code(), term()} | term()
 
-  @spec main(list(string())) :: no_return()
-  def main(["--auto-complete" | []]) do
-    handle_shutdown(:ok)
-  end
-
+  @spec main(list()) :: no_return()
   def main(unparsed_command) do
     exec_command(unparsed_command, &process_output/3)
     |> handle_shutdown
@@ -50,14 +53,13 @@ defmodule RabbitMQCtl do
     {:ok, ExitCodes.exit_ok(), Enum.join(HelpCommand.all_usage(parsed_options), "")}
   end
 
-  def exec_command(["--version"] = _unparsed_command, opts) do
+  def exec_command(["--version"] = _unparsed_command, output_fun) do
     # rewrite `--version` as `version`
-    exec_command(["version"], opts)
+    exec_command(["version"], output_fun)
   end
 
-  def exec_command(["--auto-complete" | args], opts) do
-    # rewrite `--auto-complete` as `autocomplete`
-    exec_command(["autocomplete" | args], opts)
+  def exec_command(["--auto-complete" | args], output_fun) do
+    {:ok, ExitCodes.exit_ok(), ""}
   end
 
   def exec_command(unparsed_command, output_fun) do
@@ -237,12 +239,7 @@ defmodule RabbitMQCtl do
     end
   end
 
-  @spec handle_shutdown(:ok) :: no_return()
-  defp handle_shutdown(:ok) do
-    exit_program(0)
-  end
-
-  @spec handle_shutdown({:error, integer(), nil}) :: no_return()
+  @spec handle_shutdown({:error, integer(), nil} | atom()) :: no_return()
   defp handle_shutdown({:error, exit_code, nil}) do
     exit_program(exit_code)
   end