Add rabbitmq_cli dialyze to bazel (#7066)

* Add rabbitmq_cli dialyze to bazel

and fix a number of warnings

Because we stop mix from recompiling rabbit_common in bazel, many
unknown functions are reported, so this dialyzer analysis is somewhat
incomplete.

* Use erlang dialyzer for rabbitmq_cli rather than mix dialyzer

Since this resolves all of the rabbit functions, there are far fewer
unknown functions.

Requires yet to be released rules_erlang 3.9.2

* Temporarily use pre-release rules_erlang

So that checks can run on this PR without a release

* Fix additional dialyzer warnings in rabbitmq_cli

* rabbitmq_cli: mix format

* Additional fixes for ignored return values

* Revert "Temporarily use pre-release rules_erlang"

This reverts commit c16b5b6.

* Use rules_erlang 3.9.2

Author: HoloRin

MODULE.bazel

@@ -31,7 +31,7 @@ bazel_dep(
 
 bazel_dep(
     name = "rules_erlang",
-    version = "3.9.1",
+    version = "3.9.2",
 )
 
 erlang_config = use_extension(

WORKSPACE

@@ -4,7 +4,7 @@ load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository", "new_git_r
 git_repository(
     name = "rules_erlang",
     remote = "https://github.com/rabbitmq/rules_erlang.git",
-    tag = "3.9.1",
+    tag = "3.9.2",
 )
 
 load("@rules_erlang//:internal_deps.bzl", "rules_erlang_internal_deps")

deps/rabbit_common/src/rabbit_misc.erl

@@ -232,7 +232,7 @@
 -spec pset(term(), term(), [term()]) -> [term()].
 -spec format_message_queue(any(), priority_queue:q()) -> term().
 -spec os_cmd(string()) -> string().
--spec is_os_process_alive(non_neg_integer()) -> boolean().
+-spec is_os_process_alive(non_neg_integer() | string()) -> boolean().
 -spec version() -> string().
 -spec otp_release() -> string().
 -spec otp_system_version() -> string().

deps/rabbitmq_cli/BUILD.bazel

@@ -1,10 +1,11 @@
 load("@bazel_skylib//rules:select_file.bzl", "select_file")
+load("@rules_erlang//:dialyze.bzl", "dialyze", "plt")
 load(":rabbitmqctl.bzl", "rabbitmqctl")
 load(":rabbitmqctl_check_formatted.bzl", "rabbitmqctl_check_formatted_test")
 load(":rabbitmqctl_test.bzl", "rabbitmqctl_test")
 load("//:rabbitmq_home.bzl", "rabbitmq_home")
 load("//:rabbitmq_run.bzl", "rabbitmq_run")
-load("//:rabbitmq.bzl", "STARTS_BACKGROUND_BROKER_TAG")
+load("//:rabbitmq.bzl", "RABBITMQ_DIALYZER_OPTS", "STARTS_BACKGROUND_BROKER_TAG")
 
 # Note: All the various rabbitmq-* scripts are just copies of rabbitmqctl
 rabbitmqctl(
@@ -71,6 +72,22 @@ test_suite(
     tests = ["check_formatted"],
 )
 
+plt(
+    name = "deps_plt",
+    libs = [":elixir"],
+    deps = [
+        ":elixir",
+        "//deps/rabbit:erlang_app",
+        "//deps/rabbit_common:erlang_app",
+    ],
+)
+
+dialyze(
+    dialyzer_opts = RABBITMQ_DIALYZER_OPTS,
+    libs = [":elixir"],
+    plt = ":deps_plt",
+)
+
 rabbitmqctl_test(
     name = "tests",
     size = "large",

deps/rabbitmq_cli/lib/rabbitmq/cli/command_behaviour.ex

@@ -47,7 +47,7 @@ defmodule RabbitMQ.CLI.CommandBehaviour do
   @callback printer() :: atom()
   @callback scopes() :: [atom()] | nil
   @callback description() :: String.t()
-  @callback help_section() :: String.t() | {:plugin, atom()}
+  @callback help_section() :: String.t() | atom() | {:plugin, atom()}
   @callback usage_additional() ::
               String.t()
               | [String.t()]

deps/rabbitmq_cli/lib/rabbitmq/cli/core/code_path.ex

@@ -15,7 +15,7 @@ defmodule RabbitMQ.CLI.Core.CodePath do
       val ->
         with {:ok, plugins_dir} <- val do
           String.split(to_string(plugins_dir), Platform.path_separator())
-          |> Enum.map(&add_directory_plugins_to_load_path/1)
+          |> Enum.each(&add_directory_plugins_to_load_path/1)
 
           :ok
         end
@@ -99,11 +99,11 @@ defmodule RabbitMQ.CLI.Core.CodePath do
       _ ->
         case Application.load(:rabbit) do
           :ok ->
-            Code.ensure_loaded(:rabbit_plugins)
+            _ = Code.ensure_loaded(:rabbit_plugins)
             :ok
 
           {:error, {:already_loaded, :rabbit}} ->
-            Code.ensure_loaded(:rabbit_plugins)
+            _ = Code.ensure_loaded(:rabbit_plugins)
             :ok
 
           {:error, err} ->

deps/rabbitmq_cli/lib/rabbitmq/cli/core/command_modules.ex

@@ -59,7 +59,7 @@ defmodule RabbitMQ.CLI.Core.CommandModules do
   end
 
   def plugin_modules(opts) do
-    require_rabbit(opts)
+    _ = require_rabbit(opts)
 
     enabled_plugins =
       try do

deps/rabbitmq_cli/lib/rabbitmq/cli/core/helpers.ex

@@ -130,7 +130,7 @@ defmodule RabbitMQ.CLI.Core.Helpers do
   end
 
   def apply_if_exported(mod, fun, args, default) do
-    Code.ensure_loaded(mod)
+    _ = Code.ensure_loaded(mod)
 
     case function_exported?(mod, fun, length(args)) do
       true -> apply(mod, fun, args)

deps/rabbitmq_cli/lib/rabbitmq/cli/core/input.ex

@@ -26,7 +26,7 @@ defmodule RabbitMQ.CLI.Core.Input do
   end
 
   def consume_multiline_string() do
-    val = IO.read(:stdio, :all)
+    val = IO.read(:stdio, :eof)
 
     case val do
       :eof -> :eof

deps/rabbitmq_cli/lib/rabbitmq/cli/core/memory.ex

@@ -90,7 +90,7 @@ defmodule RabbitMQ.CLI.Core.Memory do
   end
 
   def parse_watermark(n) when is_bitstring(n) do
-    case IU.parse(n) do
+    case IU.parse(to_charlist(n)) do
       {:ok, parsed} -> parsed
       err -> err
     end