Feature flags: Add virgin node init support to v2 code path #6682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
add-feature-flags-v2-virgin-node-init-support
branch
from
bf973c2 to
14ae1b5
Compare
dumbbell
changed the title
Collaborator
Author
|
Note that I widened the scope of this pull request to make the v2 code path required. The description was updated accordingly. |
dumbbell
force-pushed
the
add-feature-flags-v2-virgin-node-init-support
branch
3 times, most recently
from
4cddbee to
3470fcf
Compare
dumbbell
changed the title
dumbbell
force-pushed
the
add-feature-flags-v2-virgin-node-init-support
branch
2 times, most recently
from
8121f1d to
de54251
Compare
Collaborator
Author
|
I marked this pull request as draft again because I would like to sort out the problem I describe in #6701 (comment) first. |
dumbbell
force-pushed
the
add-feature-flags-v2-virgin-node-init-support
branch
from
de54251 to
0d3639d
Compare
So far, when a new node is started, the feature flags v1 code is used to enable all stable feature flags (the default behavior). In the list, there would be `feature_flags_v2`, so this one would be enabled first and all others would be using the v2 code path. If we mark `feature_flags_v2` as required, the v2 code path didn't handle this so far. This patch adds this missing code. Now, a virgin node's feature flags can be enabled fully using the v2 code path. As part of that, th `get_forced_feature_flag_names()` function is moved from `rabbit_feature_flags` to `rabbit_ff_controller`.
dumbbell
force-pushed
the
add-feature-flags-v2-virgin-node-init-support
branch
from
0d3639d to
bb501a0
Compare
…nal use The two exported functions are used by the testsuite. They should be exported when `TEST` is defined only, but the way mixed-version testing is implemented in Bazel forces us to export them.
dumbbell
force-pushed
the
add-feature-flags-v2-virgin-node-init-support
branch
from
bb501a0 to
80da804
Compare
dumbbell
changed the title
dumbbell
added a commit
that referenced
this pull request
Jan 9, 2023
Feature flags: Add virgin node init support to v2 code path (backport #6682)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, when a new node is started, the feature flags v1 code is used to enable all stable feature flags (the default behavior). In the list, there would be
feature_flags_v2, so this one would be enabled first and all others would be using the v2 code path.If we mark
feature_flags_v2as required, the v2 code path didn't handle this so far. This patch adds this missing code. Now, a virgin node's feature flags can be enabled fully using the v2 code path.As part of that, the
get_forced_feature_flag_names()function is moved fromrabbit_feature_flagstorabbit_ff_controller.It depends on #6791.
Update: The patch was split into two parts, this one (which was the initial scope) and #6810.