rabbit_feature_flags: Make several fixes to enable_feature_flag_when_ff_file_is_unwritable testcase

The testcase was moved to another testsuite but called functions from
its initial testsuite. That code code relies on the name of the
testsuite so it broke.

At the same time, make it depend on the testsuite's feature flag, not
stream queues. The stream queues feature flag will become required at
some point and break the testcase.

Author: dumbbell

deps/rabbit/test/feature_flags_SUITE.erl

@@ -589,14 +589,14 @@ enable_unsupported_feature_flag_in_a_healthy_situation(Config) ->
 
 enable_feature_flag_when_ff_file_is_unwritable(Config) ->
     Supported = rabbit_ct_broker_helpers:is_feature_flag_supported(
-                  Config, stream_queue),
+                  Config, ff_from_testsuite),
     case Supported of
         true  -> do_enable_feature_flag_when_ff_file_is_unwritable(Config);
-        false -> {skip, "Stream queues are unsupported"}
+        false -> {skip, "Test feature flag is unsupported"}
     end.
 
 do_enable_feature_flag_when_ff_file_is_unwritable(Config) ->
-    FeatureName = stream_queue,
+    FeatureName = ff_from_testsuite,
     ClusterSize = ?config(rmq_nodes_count, Config),
     Node = ClusterSize - 1,
     True = lists:duplicate(ClusterSize, true),
@@ -1136,14 +1136,19 @@ prepare_my_plugin(Config) ->
         false ->
             build_my_plugin(Config);
         _ ->
-            MyPluginDir = filename:dirname(filename:dirname(code:where_is_file("my_plugin.app"))),
+            MyPluginDir = filename:dirname(
+                            filename:dirname(
+                              code:where_is_file("my_plugin.app"))),
             PluginsDir = filename:dirname(MyPluginDir),
-            rabbit_ct_helpers:set_config(Config,
-                                         [{rmq_plugins_dir, PluginsDir}])
+            rabbit_ct_helpers:set_config(
+              Config, [{rmq_plugins_dir, PluginsDir}])
     end.
 
 build_my_plugin(Config) ->
-    PluginSrcDir = filename:join(?config(data_dir, Config), "my_plugin"),
+    DataDir = filename:join(
+                filename:dirname(filename:dirname(?config(data_dir, Config))),
+                ?MODULE_STRING ++ "_data"),
+    PluginSrcDir = filename:join(DataDir, "my_plugin"),
     PluginsDir = filename:join(PluginSrcDir, "plugins"),
     Config1 = rabbit_ct_helpers:set_config(Config,
                                            [{rmq_plugins_dir, PluginsDir}]),

deps/rabbit/test/feature_flags_with_unpriveleged_user_SUITE.erl

@@ -53,10 +53,6 @@ init_per_suite(Config) ->
 end_per_suite(Config) ->
     feature_flags_SUITE:end_per_suite(Config).
 
-init_per_group(enabling_in_cluster, Config) ->
-    rabbit_ct_helpers:set_config(
-      Config,
-      [{rmq_nodes_count, 3}]);
 init_per_group(Group, Config) ->
     feature_flags_SUITE:init_per_group(Group, Config).