Feature flags: Sync enabled feature flags differently on virgin node #6791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
enable-remote-ff-on-virgin-node
branch
from
bad9b97 to
bc8b53f
Compare
dumbbell
force-pushed
the
enable-remote-ff-on-virgin-node
branch
from
bc8b53f to
a36a3aa
Compare
dumbbell
force-pushed
the
enable-remote-ff-on-virgin-node
branch
from
a36a3aa to
854cbb4
Compare
dumbbell
force-pushed
the
enable-remote-ff-on-virgin-node
branch
from
854cbb4 to
f171843
Compare
…n node If a virgin node starts as clustered (thanks to peer discovery), we need to mark feature flags already enabled remotely as enabled locally too. We can't do a regular cluster sync because remote nodes may have required feature flags which are disabled locally on the virgin node. Therefore, those nodes don't have the migration code for these feature flags anymore and the feature flags' state can't be changed. By doing this special sync, we allow a clustered virgin node to join a cluster with remote nodes having required feature flags.
dumbbell
force-pushed
the
enable-remote-ff-on-virgin-node
branch
from
f171843 to
2f301b4
Compare
dumbbell
changed the title
dumbbell
added a commit
that referenced
this pull request
Jan 9, 2023
Feature flags: Sync enabled feature flags differently on virgin node (backport #6791)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a virgin node starts as clustered (thanks to peer discovery), we need to mark feature flags already enabled remotely as enabled locally too.
We can't do a regular cluster sync because remote nodes may have required feature flags which are disabled locally on the virgin node. Therefore, those nodes don't have the migration code for these feature flags anymore and the feature flags' state can't be changed.
By doing this special sync, we allow a clustered virgin node to join a cluster with remote nodes having required feature flags.