(FM-4918) update modsync / Restrict Rake ~> 10.1 #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Iristyle ping - these could really be pulled in. |
|
Three commits - this will need squashed down. |
|
@puppetlabs/windows ModSync |
ferventcoder
changed the title
|
This is not going to fix the issue at hand yet - that is rodjek/rspec-puppet#361. But for some reason it affects rspec-puppet at 2.3.0 through 2.3.2 (and likely more, I haven't dug in too deep yet). Original break here: https://travis-ci.com/puppetlabs/puppetlabs-sqlserver/jobs/34981476 |
| gem 'rspec', '~>3.0.0', :require => false | ||
| gem 'rake', '~>10.1', :require => false | ||
| gem 'rspec', '~>3.0', :require => false | ||
| #gem 'rspec-puppet', '2.3.0', :require => false |
There was a problem hiding this comment.
Dropped this in here for a minute.
ferventcoder
changed the title
Beaker needs a version of Rake less than 11 due to using `last_comment' in rake_task.rb:62. Reduce the version of Rake down to the same dependency that Beaker does as a development dependency. Paired with Glenn Sarti <glenn.sarti at puppetlabs dot com> Puppet v4 needs facts to not be symbols, otherwise it causes rspec-puppet to fail with `expected Puppet::Error with message matching /expects a value for parameter 'admin_user'/, got <Puppet::Error: Unsupported data type: 'Symbol'`. Paired with David Schmitt
ferventcoder
changed the title
| - gem: puppet-lint | ||
| - gem: puppetlabs_spec_helper | ||
| version: '~>0.10.3' | ||
| - gem: puppet_facts | ||
| - gem: mocha | ||
| version: '~>0.10.5' | ||
| - gem: pry |
There was a problem hiding this comment.
I know that it's in the development group, but should we be requiring pry by default?
Nevermind, it's coming from modulesync.
glennsarti
added a commit
that referenced
this pull request
Mar 14, 2016
(FM-4918) update modsync / Restrict Rake ~> 10.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beaker needs a version of Rake less than
11 due to using `last_comment' in
rake_task.rb:62. Reduce the version of Rake
down to the same dependency that Beaker does
as a development dependency.
Paired with Glenn Sarti <glenn.sarti at puppetlabs dot com>