Skip to content

(FM-4918) update modsync / Restrict Rake ~> 10.1 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
pkg/
Gemfile.lock
Gemfile.local
vendor/
spec/fixtures/
log/
junit/
Expand Down
4 changes: 3 additions & 1 deletion .sync.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,16 @@ Gemfile:
required:
':development':
- gem: rake
version: '~>10.1'
- gem: rspec
version: '~>3.0.0'
version: '~>3.0'
- gem: puppet-lint
- gem: puppetlabs_spec_helper
version: '~>0.10.3'
- gem: puppet_facts
- gem: mocha
version: '~>0.10.5'
- gem: pry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that it's in the development group, but should we be requiring pry by default?

Nevermind, it's coming from modulesync.

- gem: simplecov
- gem: yard
':system_tests':
Expand Down
3 changes: 0 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,5 @@ matrix:
env: PUPPET_GEM_VERSION="3.7.0"
- rvm: 2.0.0
env: PUPPET_GEM_VERSION="3.7.0"
allow_failures:
- rvm: 2.1.5
env: PUPPET_GEM_VERSION="~> 4.0"
notifications:
email: false
21 changes: 19 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,24 @@ def location_for(place_or_version, fake_version = nil)
end
end

# The following gems are not included by default as they require DevKit on Windows.
# You should probably include them in a Gemfile.local or a ~/.gemfile
#gem 'pry' #this may already be included in the gemfile
#gem 'pry-stack_explorer', :require => false
#if RUBY_VERSION =~ /^2/
# gem 'pry-byebug'
#else
# gem 'pry-debugger'
#end

group :development do
gem 'rake', :require => false
gem 'rspec', '~>3.0.0', :require => false
gem 'rake', '~>10.1', :require => false
gem 'rspec', '~>3.0', :require => false
gem 'puppet-lint', :require => false
gem 'puppetlabs_spec_helper', '~>0.10.3', :require => false
gem 'puppet_facts', :require => false
gem 'mocha', '~>0.10.5', :require => false
gem 'pry', :require => false
gem 'simplecov', :require => false
gem 'yard', :require => false
end
Expand Down Expand Up @@ -110,8 +121,14 @@ if explicitly_require_windows_gems
gem "windows-pr", "1.2.3", :require => false
end

# Evaluate Gemfile.local if it exists
if File.exists? "#{__FILE__}.local"
eval(File.read("#{__FILE__}.local"), binding)
end

# Evaluate ~/.gemfile if it exists
if File.exists?(File.join(Dir.home, '.gemfile'))
eval(File.read(File.join(Dir.home, '.gemfile')), binding)
end

# vim:ft=ruby
1 change: 0 additions & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ matrix:
fast_finish: true
install:
- SET PATH=C:\Ruby%RUBY_VER%\bin;%PATH%
- gem install bundler --quiet --no-ri --no-rdoc
- bundle install --jobs 4 --retry 2 --without system_tests
- type Gemfile.lock
build: off
Expand Down
2 changes: 1 addition & 1 deletion spec/defines/config_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

RSpec.describe 'sqlserver::config', :type => :define do
let(:title) { 'MSSQLSERVER' }
let(:facts) { {:osfamily => 'windows', :platform => :windows, :puppet_vardir => 'C:/ProgramData/PuppetLabs/puppet/var'} }
let(:facts) { {:osfamily => 'windows', :platform => 'windows', :puppet_vardir => 'C:/ProgramData/PuppetLabs/puppet/var'} }

describe 'compile' do
let(:params) { {
Expand Down
3 changes: 3 additions & 0 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
RSpec.configure do |c|
c.module_path = File.join(fixture_path, 'modules')
c.manifest_dir = File.join(fixture_path, 'manifests')
c.expect_with :rspec do |e|
e.syntax = [:should, :expect]
end
end

SimpleCov.start do
Expand Down