(FM-3940) Fix specs - Puppet 4.x validation errors #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferventcoder
changed the title
|
As a followup, we should merge #153 - that will allow TravisCI to fail properly instead of allowing 4.x as an allowed failure. |
The validation error message for missing parameters for defined types has changed from "Must pass ___ to ___" to "expects a value for parameter '___'". The specs must be evaluated based on the version of Puppet they are running under. Add specs for config to test missing admin_user/admin_pass to verify the values are validated properly.
Remove acceptance tests that deal with validation errors as those are now covered by specs.
| } | ||
| MANIFEST | ||
| apply_manifest_on(host, pp, {:acceptable_exit_codes => [0,1]}) do |r| | ||
| expect(r.stderr).to match(/Error: Must pass admin_user to Sqlserver/) |
There was a problem hiding this comment.
Originally I had adjusted this to /Error: Must pass admin_user to Sqlserver|expects a value for parameter 'admin_user'/ but @cowofevil stated that these specs are no longer necessary due to spec coverage.
cowofevil
pushed a commit
that referenced
this pull request
Dec 7, 2015
…tance-fixes (FM-3940) Fix specs - Puppet 4.x validation errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation error message for missing parameters for defined
types has changed from
Must pass ___ to ___toexpects a value for parameter '___'. The specs must be evaluated based on theversion of Puppet they are running under.
Add specs for config to test missing admin_user/admin_pass to
verify the values are validated properly.