Skip to content

(FM-3940) Fix specs - Puppet 4.x validation errors #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2015
Merged

(FM-3940) Fix specs - Puppet 4.x validation errors #155

merged 2 commits into from
Dec 7, 2015

Conversation

ferventcoder
Copy link
Contributor

The validation error message for missing parameters for defined
types has changed from Must pass ___ to ___ to expects a value for parameter '___'. The specs must be evaluated based on the
version of Puppet they are running under.

Add specs for config to test missing admin_user/admin_pass to
verify the values are validated properly.

@ferventcoder ferventcoder changed the title (FM-3940) Fixes related to specs (FM-3940) Fix specs - Puppet 4.x validation errors Dec 7, 2015
@ferventcoder
Copy link
Contributor Author

As a followup, we should merge #153 - that will allow TravisCI to fail properly instead of allowing 4.x as an allowed failure.

The validation error message for missing parameters for defined
types has changed from "Must pass ___ to ___" to "expects a value
for parameter '___'". The specs must be evaluated based on the
version of Puppet they are running under.

Add specs for config to test missing admin_user/admin_pass to
verify the values are validated properly.
Remove acceptance tests that deal with validation errors as
those are now covered by specs.
}
MANIFEST
apply_manifest_on(host, pp, {:acceptable_exit_codes => [0,1]}) do |r|
expect(r.stderr).to match(/Error: Must pass admin_user to Sqlserver/)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally I had adjusted this to /Error: Must pass admin_user to Sqlserver|expects a value for parameter 'admin_user'/ but @cowofevil stated that these specs are no longer necessary due to spec coverage.

cowofevil pushed a commit that referenced this pull request Dec 7, 2015
…tance-fixes

(FM-3940) Fix specs - Puppet 4.x validation errors
@cowofevil cowofevil merged commit 356a305 into puppetlabs:stable Dec 7, 2015
@cowofevil cowofevil deleted the ticket/stable/FM-3940-acceptance-fixes branch December 7, 2015 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants