-
Notifications
You must be signed in to change notification settings - Fork 39
Update Http\Client\Exception to extend \Throwable #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Include dstuecken/php7ify to provide a \Throwable polyfill for versions of PHP earlier than 7.0. Resolves #142
The Travis CI build is failing only on HHVM, and I don't believe it's a result of this change. Here's the error:
|
This looks like a duplicate of #144 |
Ah, okay, I missed the polyfill. This one could actually be the (short-term) solution then, since we don't have any plans (yet?) to require PHP 7.x in HTTPlug 1.y. |
i would be fine with this change as a new minor 1.x version until 2.0 is released. psr-18 is in vote phase - @Nyholm is this the last step and it becomes an official standard right after that, so we would release httplug 2.0 this month still? re hhvm: yes, i think it has a tendency of deteriorating. we can ignore the failure in this PR as its not related (i restarted the latest master build and got the same: https://travis-ci.org/php-http/httplug/jobs/317959290). hhvm became completely irrelevant for all i know, i guess we should drop testing with it. |
see #146 for hhvm |
It's the last step |
cool! is it worth it to still merge this, or do we not bother anymore? there is no other significant change in master atm since the latest 1.1.0 release: v1.1.0...master |
I don't think we should bother. =) This is now fixed in master. Thank you @ramsey for this PR. Im going to close this. |
What's in this PR?
Updates
Http\Client\Exception
to extend from\Throwable
. Also includes dstuecken/php7ify to provide a\Throwable
polyfill for versions of PHP earlier than 7.0.Why?
Static analysis tools are complaining when creating HTTP clients that implement
Http\Client\HttpClient
Example Usage
n/a
Checklist
Will update the CHANGELOG if this approach is acceptable to the maintainers.
To Do
n/a