Update minimum PHP version to ^7.0 and modify Http\Client\Exception to extend \Throwable #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the library to support only PHP version 7.0.0 and greater, to allow use of the \Throwable interface, introduced in PHP 7. Resolves #142
1 task
|
I believe this should happen as part of the PSR-18 upgrade, until then I see no point in this change. /cc @Nyholm |
|
Yeah, check out the 2.x branch. I think we should merge that one to master now. |
Merged
|
This is fixed in master. Thank you for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Updates
Http\Client\Exceptionto extend from\Throwable. Also updates the library to support only PHP version 7.0.0 and greater, to allow use of the\Throwableinterface, introduced in PHP 7.Why?
Static analysis tools are complaining when creating HTTP clients that implement
Http\Client\HttpClientExample Usage
n/a
Checklist
Will update the CHANGELOG if this approach is acceptable to the maintainers.
To Do
n/a