Skip to content

Update minimum PHP version to ^7.0 and modify Http\Client\Exception to extend \Throwable #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ramsey
Copy link

@ramsey ramsey commented Oct 17, 2018

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #142
License MIT

What's in this PR?

Updates Http\Client\Exception to extend from \Throwable. Also updates the library to support only PHP version 7.0.0 and greater, to allow use of the \Throwable interface, introduced in PHP 7.

Why?

Static analysis tools are complaining when creating HTTP clients that implement Http\Client\HttpClient

Example Usage

n/a

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix

Will update the CHANGELOG if this approach is acceptable to the maintainers.

To Do

n/a

Update the library to support only PHP version 7.0.0 and greater, to
allow use of the \Throwable interface, introduced in PHP 7.

Resolves #142
@sagikazarmark
Copy link
Member

I believe this should happen as part of the PSR-18 upgrade, until then I see no point in this change.

/cc @Nyholm

@Nyholm
Copy link
Member

Nyholm commented Oct 18, 2018

Yeah, check out the 2.x branch. I think we should merge that one to master now.

@Nyholm Nyholm mentioned this pull request Oct 18, 2018
@Nyholm
Copy link
Member

Nyholm commented Oct 27, 2018

This is fixed in master. Thank you for this PR.

@Nyholm Nyholm closed this Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

phpstan complains about Http\Client\Exception
3 participants