Skip to content

stop building with hhvm because it stopped working #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Oct 18, 2018

it seems a recent version of hhvm did a BC break, builds that have been successful now fail with

Fatal error: Uncaught TypeError: Argument 1 passed to spec\Http\Client\Exception\HttpExceptionSpec::let() 
must implement interface Psr\Http\Message\RequestInterface, PhpSpec\Wrapper\Collaborator given
 in /home/travis/build/php-http/httplug/spec/Exception/HttpExceptionSpec.php:14
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
Documentation -
License MIT

What's in this PR?

Drop HHVM support

Why?

HHVM build stopped working, and HHVM seems not relevant enough anymore to figure out why.

Checklist

no changelog entry and no doc change needed.

it seems a recent version of hhvm did a BC break, builds that have been successful now fail with
```
Fatal error: Uncaught TypeError: Argument 1 passed to spec\Http\Client\Exception\HttpExceptionSpec::let() must implement interface Psr\Http\Message\RequestInterface, PhpSpec\Wrapper\Collaborator given in /home/travis/build/php-http/httplug/spec/Exception/HttpExceptionSpec.php:14
```
@Nyholm Nyholm merged commit 7e29605 into master Oct 18, 2018
@joelwurtz joelwurtz deleted the drop-hhvm branch October 18, 2018 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants