(っ˘▽˘)っ ☁️☁️☁️ ⊂(◕。◕⊂) #2
Conversation
|
I love how this is using our commit style. |
|
@nlutsenko we've learnt from the best! |
| @@ -19,8 +19,7 @@ | |||
| jsonObject.put("op", "subscribe"); | |||
| jsonObject.put("requestId", requestId); | |||
|
|
|||
| ParseEncoder encoder = PointerEncoder.get(); | |||
| JSONObject queryJsonObject = state.toJSON(encoder); | |||
| JSONObject queryJsonObject = state.toJSON(NoObjectsEncoder.get()); | |||
There was a problem hiding this comment.
Why NoObjectsEncoder? I was testing this, and wasn't able to get it to compare a pointer field to a ParseObject that represents the expected field value. Nothing got sent over the socket though, which prompted me to dig deeper. Turns out that uncovered a different issue, which I'm also fixing along the way. But when I changed this back to PointerEncoder, my .whereEquals("key", theParseObj) predicate suddenly started working correctly.
What was the reason for changing this?
There was a problem hiding this comment.
Reverted that change. I thought I tested with the NoObjectsEncoder but seems not. Good catch.
| } | ||
|
|
||
| private void sendSubscription(Subscription<T> subscription) { | ||
| sendOperationAsync(new SubscribeClientOperation<>(subscription.getRequestId(), subscription.getQueryState())); |
There was a problem hiding this comment.
This swallows exceptions thrown by the ClientOperation. In my case, it was an IllegalArgumentException thrown by NoObjectsEncoder when given a ParseObject.
I have a local commit to fix this by dispatching it into HandleErrorCallback.onError().
Should I push those commits here, or wait for this initial code to get merged and then make a new PR for that?
If the query can't be encoded (or any other checked or unchecked Exception occurs), the async SubscribeClientOperation will swallow the exception, leaving no way (even a log message) to see why it failed. This creates a new LiveQueryException subclass (UnknownException) to represent an unexpected RuntimeException that can then be handled by the HandleErrorCallback#onError() callback.
|
What's going on with this project? |
|
@flovilmart @nlutsenko @mmimeault |
|
@jhansche nothing's holding on our side, besides a thourough review of the core, and perhaps credentials to publish on a package manager . @mmimeault? |
This allows the results to be chained together via tasks, and also allows the CurrentUserController to be overridden to provide additional functionality for retrieving the session token. This matches how the ParseCloud and ParseObject retrieve the session token.
|
Hello, sorry for the downtime on this. @jhansche Could you please give more information about your problems you having other than the Encoder with this PR? It would be nice to merge it in master and make it publicly available if it works. Giving you an update really soon about the encoding problem. |
|
Everything seems to works really fine on my side. Seen your PRs. Do you think we are ready to merge that in master? Or there is still things we should finish first? |
I've been using it with just the two changes in PR here for a couple months now. We haven't had any other issues aside from those two changes. |
|
awesome @jhansche, we will just need to configure the release and build check after that. |
Add support for `sessionToken` in "connect" and "subscribe" operations
Unswallow subscribe errors
(っ˘▽˘)っ ☁️☁️☁️ ⊂(◕。◕⊂)