Unswallow subscribe errors #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 14, 2016 13:36
If the query can't be encoded (or any other checked or unchecked Exception occurs), the async SubscribeClientOperation will swallow the exception, leaving no way (even a log message) to see why it failed. This creates a new LiveQueryException subclass (UnknownException) to represent an unexpected RuntimeException that can then be handled by the HandleErrorCallback#onError() callback.
|
Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subscribe() method ignores any errors thrown while the Task is executing. This adds a unit test and dispatches the thrown errors to onError()