Add support for sessionToken in "connect" and "subscribe" operations
#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 6, 2017 13:11
This allows the results to be chained together via tasks, and also allows the CurrentUserController to be overridden to provide additional functionality for retrieving the session token. This matches how the ParseCloud and ParseObject retrieve the session token.
|
Today's commits add unit tests, and switch to |
mmimeault
reviewed
Feb 16, 2017
| } | ||
|
|
||
| @Override | ||
| /* package */ JSONObject getJSONObjectRepresentation() throws JSONException { | ||
| JSONObject jsonObject = new JSONObject(); | ||
| jsonObject.put("op", "subscribe"); | ||
| jsonObject.put("requestId", requestId); | ||
| if (sessionToken != null) jsonObject.put("sessionToken", sessionToken); |
There was a problem hiding this comment.
In ConnectClientOperation we always the sessionToken, even if it's null.
Should we add the null check also in ConnectClientOperation?
There was a problem hiding this comment.
I don't think the null check is required. The field itself is optional anyway. I just didn't pay attention to the way ConnectClientOperation did it.
I'd be fine with removing the null check if we want them to be consistent.
|
Otherwise it look pretty good. |
|
awesome +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/ParsePlatform/parse-server/wiki/Parse-LiveQuery-Protocol-Specification