Skip to content

TST: troubleshoot strict=False xfails #49820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Dec 13, 2022
Merged

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Nov 21, 2022
@jbrockmendel
Copy link
Member Author

dont merge, i want to re-run a few times to see if the flaky fails come back

@mroeschke
Copy link
Member

I'll mark this PR as a draft to signal not to merge

@mroeschke mroeschke marked this pull request as draft November 23, 2022 18:34
@jbrockmendel jbrockmendel marked this pull request as ready for review December 7, 2022 23:10
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge when ready

@jbrockmendel jbrockmendel merged commit 749d59d into pandas-dev:main Dec 13, 2022
@jbrockmendel jbrockmendel deleted the stricts branch December 13, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants