TST: troubleshoot strict=False xfails

pandas/tests/base/test_unique.py

@@ -105,9 +105,6 @@ def test_nunique_null(null_obj, index_or_series_obj):
 
 
 @pytest.mark.single_cpu
-@pytest.mark.xfail(
-    reason="Flaky in the CI. Remove once CI has a single build: GH 44584", strict=False
-)
 def test_unique_bad_unicode(index_or_series):
     # regression test for #34550
     uval = "\ud83d"  # smiley emoji

pandas/tests/computation/test_eval.py

@@ -860,19 +860,6 @@ def test_basic_frame_series_alignment(
     def test_basic_series_frame_alignment(
         self, request, engine, parser, index_name, r_idx_type, c_idx_type
     ):
-        if (
-            engine == "numexpr"
-            and parser == "pandas"
-            and index_name == "index"
-            and r_idx_type == "i"
-            and c_idx_type == "s"
-        ):
-            reason = (
-                f"Flaky column ordering when engine={engine}, "
-                f"parser={parser}, index_name={index_name}, "
-                f"r_idx_type={r_idx_type}, c_idx_type={c_idx_type}"
-            )
-            request.node.add_marker(pytest.mark.xfail(reason=reason, strict=False))
         df = tm.makeCustomDataframe(
             10, 7, data_gen_f=f, r_idx_type=r_idx_type, c_idx_type=c_idx_type
         )

pandas/tests/extension/json/test_json.py

@@ -276,7 +276,6 @@ def test_combine_add(self, data_repeated):
     @pytest.mark.xfail(
         reason="combine for JSONArray not supported - "
         "may pass depending on random data",
-        strict=False,
     )
     def test_combine_first(self, data):
         super().test_combine_first(data)

pandas/tests/frame/test_constructors.py

@@ -3139,12 +3139,6 @@ def test_frame_allow_non_nano(self, arr):
         df = DataFrame(arr)
         assert df.dtypes[0] == arr.dtype
 
-    @pytest.mark.xfail(
-        # TODO(2.0): xfail should become unnecessary
-        strict=False,
-        reason="stack_arrays converts TDA to ndarray, then goes "
-        "through ensure_wrapped_if_datetimelike",
-    )
     def test_frame_from_dict_allow_non_nano(self, arr):
         df = DataFrame({0: arr})
         assert df.dtypes[0] == arr.dtype

pandas/tests/io/parser/test_network.py

@@ -80,11 +80,6 @@ def tips_df(datapath):
 
 @pytest.mark.single_cpu
 @pytest.mark.usefixtures("s3_resource")
-@pytest.mark.xfail(
-    reason="CI race condition GH 45433, GH 44584",
-    raises=FileNotFoundError,
-    strict=False,
-)
 @td.skip_if_not_us_locale()
 class TestS3:
     @td.skip_if_no("s3fs")
@@ -226,7 +221,6 @@ def test_read_s3_fails(self, s3so):
         with pytest.raises(OSError, match=msg):
             read_csv("s3://cant_get_it/file.csv")
 
-    @pytest.mark.xfail(reason="GH#39155 s3fs upgrade", strict=False)
     def test_write_s3_csv_fails(self, tips_df, s3so):
         # GH 32486
         # Attempting to write to an invalid S3 path should raise
@@ -242,7 +236,6 @@ def test_write_s3_csv_fails(self, tips_df, s3so):
                 "s3://an_s3_bucket_data_doesnt_exit/not_real.csv", storage_options=s3so
             )
 
-    @pytest.mark.xfail(reason="GH#39155 s3fs upgrade", strict=False)
     @td.skip_if_no("pyarrow")
     def test_write_s3_parquet_fails(self, tips_df, s3so):
         # GH 27679

pandas/tests/plotting/frame/test_frame.py

@@ -11,6 +11,7 @@
 import numpy as np
 import pytest
 
+from pandas.compat import is_platform_windows
 import pandas.util._test_decorators as td
 
 from pandas.core.dtypes.api import is_list_like
@@ -474,6 +475,7 @@ def test_line_lim(self):
             assert xmax >= lines[0].get_data()[0][-1]
 
     @pytest.mark.xfail(
+        not is_platform_windows(),
         strict=False,
         reason="2020-12-01 this has been failing periodically on the "
         "ymin==0 assertion for a week or so.",